Re: [PATCH v6] Implement backend program convention command for vhost-user-blk

[Stefan Hajnoczi]

On Thu, Nov 21, 2019 at 09:58:26AM +0800, Micky Yun Chan wrote:
> diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json
> index da6aaf51c8..d25c3a957f 100644
> --- a/docs/interop/vhost-user.json
> +++ b/docs/interop/vhost-user.json
> @@ -54,6 +54,37 @@
>    ]
>  }
>  
> +##
> +# @VHostUserBackendBlockFeature:
> +#
> +# List of vhost user "block" features.
> +#
> +# @read-only: The --read-only command line option is supported.
> +# @blk-file: The --blk-file command line option is supported.

Please also update docs/interop/vhost-user.rst.  That document
duplicates the option documentation and it would be good to keep it
up-to-date.

> +#
> +# Since: 4.0

QEMU 4.2 is close to being released and the codebase is frozen.  The
next release will be 5.0.  Please change this to:

  Since: 5.0

> +##
> +{
> +  'enum': 'VHostUserBackendBlockFeature',
> +  'data': [ 'read-only', 'blk-file' ]
> +}
> +
> +##
> +# @VHostUserBackendCapabilitiesBlock:
> +#
> +# Capabilities reported by vhost user "block" backends
> +#
> +# @features: list of supported features.
> +#
> +# Since: 4.0

Same here.

signature.asc
Description: PGP signature