[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 20/37] mips: use sysbus_mmio_get_region() instead of inter
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v4 20/37] mips: use sysbus_mmio_get_region() instead of internal fields |
|
Date: |
Thu, 21 Nov 2019 13:48:26 +0000 |
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau
<address@hidden> wrote:
>
> Register the memory region with sysbus_init_mmio() and look it up with
> sysbus_mmio_get_region() to avoid accessing internal device fields.
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/char/serial.c | 1 +
> hw/mips/mips_mipssim.c | 3 ++-
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, (continued)
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Philippe Mathieu-Daudé, 2019/11/25
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Aleksandar Markovic, 2019/11/25
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Philippe Mathieu-Daudé, 2019/11/25
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Philippe Mathieu-Daudé, 2019/11/25
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Marc-André Lureau, 2019/11/27
- Re: [PATCH v4 18/37] mips: baudbase is 115200 by default, Aleksandar Markovic, 2019/11/27
[PATCH v4 19/37] mips: use sysbus_add_io(), Marc-André Lureau, 2019/11/20
[PATCH v4 20/37] mips: use sysbus_mmio_get_region() instead of internal fields, Marc-André Lureau, 2019/11/20
[PATCH v4 21/37] sm501: make SerialMM a child, export chardev property, Marc-André Lureau, 2019/11/20
[PATCH v4 22/37] vmmouse: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/11/20
[PATCH v4 23/37] lance: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/11/20
[PATCH v4 24/37] etraxfs: remove PROP_PTR usage, Marc-André Lureau, 2019/11/20
[PATCH v4 25/37] dp8393x: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/11/20
[PATCH v4 26/37] leon3: use qemu_irq framework instead of callback as property, Marc-André Lureau, 2019/11/20