Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards

[Laurent Vivier]

Le 20/11/2019 à 03:26, Aleksandar Markovic a écrit :
> 
> 
> On Tuesday, November 19, 2019, Richard Henderson
> <address@hidden <mailto:address@hidden>> wrote:
> 
>     On 11/19/19 6:22 PM, Taylor Simpson wrote:
>     > - Laurent suggested I split the patch into two parts: linux-user
>     and target/hexagon.  If I do that, which one should contain the
>     changes to common files (e.g., configure)?  Also, note that we won't
>     be able to build until both patches are merged.  Is that OK?
> 
>     The configure parts should be a third, last, patch.
> 
>     The series is bisectable, because before the configure patch,
>     none of the hexagon code is compiled at all.
> 
> 
> I don't think this is a good advice. Yes, at first glance, that would
> make the submitter's job easier - since he could divide the whole code
> into parts practicaly arbitrarily - but the resulting series will be of
> suboptimal quality. If the submitter was forced from the outset to add
> segments of his solution so that each step actually (not only
> ostensibly) compiles, he would also be forced to organize patches in
> much more coherent way, organize his code in much more modular way,
> possibly improve initial organization, additionally making reviews much
> easier.

I totally agree with you but in this case I don't see a simple solution
to be able to compile each part separately.

If there will be problems in the way the code is divided in patches, we
can point out the problem during review.

Thanks,
Laurent