[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v5 05/23] ppc/pnv: Quiesce some XIVE errors
From: |
David Gibson |
Subject: |
Re: [PATCH for-5.0 v5 05/23] ppc/pnv: Quiesce some XIVE errors |
Date: |
Wed, 20 Nov 2019 09:07:50 +1100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Nov 15, 2019 at 05:24:18PM +0100, Cédric Le Goater wrote:
> When dumping the END and NVT tables, the error logging is too noisy.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Applied, thanks.
> ---
> hw/intc/pnv_xive.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c
> index 02faf4135e48..a394331ddd6a 100644
> --- a/hw/intc/pnv_xive.c
> +++ b/hw/intc/pnv_xive.c
> @@ -29,7 +29,7 @@
>
> #include "pnv_xive_regs.h"
>
> -#define XIVE_DEBUG
> +#undef XIVE_DEBUG
>
> /*
> * Virtual structures table (VST)
> @@ -157,7 +157,9 @@ static uint64_t pnv_xive_vst_addr_indirect(PnvXive *xive,
> uint32_t type,
> vsd = ldq_be_dma(&address_space_memory, vsd_addr);
>
> if (!(vsd & VSD_ADDRESS_MASK)) {
> +#ifdef XIVE_DEBUG
> xive_error(xive, "VST: invalid %s entry %x !?", info->name, idx);
> +#endif
> return 0;
> }
>
> @@ -178,7 +180,9 @@ static uint64_t pnv_xive_vst_addr_indirect(PnvXive *xive,
> uint32_t type,
> vsd = ldq_be_dma(&address_space_memory, vsd_addr);
>
> if (!(vsd & VSD_ADDRESS_MASK)) {
> +#ifdef XIVE_DEBUG
> xive_error(xive, "VST: invalid %s entry %x !?", info->name, idx);
> +#endif
> return 0;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH for-5.0 v5 02/23] ppc/xive: Introduce helpers for the NVT id, (continued)
- [PATCH for-5.0 v5 02/23] ppc/xive: Introduce helpers for the NVT id, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 03/23] ppc/pnv: Remove pnv_xive_vst_size() routine, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 04/23] ppc/pnv: Dump the XIVE NVT table, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 05/23] ppc/pnv: Quiesce some XIVE errors, Cédric Le Goater, 2019/11/15
- Re: [PATCH for-5.0 v5 05/23] ppc/pnv: Quiesce some XIVE errors,
David Gibson <=
- [PATCH for-5.0 v5 06/23] ppc/xive: Introduce OS CAM line helpers, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 07/23] ppc/xive: Check V bit in TM_PULL_POOL_CTX, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 08/23] ppc/xive: Introduce a XivePresenter interface, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 09/23] ppc/xive: Implement the XivePresenter interface, Cédric Le Goater, 2019/11/15
- [PATCH for-5.0 v5 10/23] ppc/pnv: Loop on the threads of the chip to find a matching NVT, Cédric Le Goater, 2019/11/15