Re: [PATCH] linux-user/strace: Add missing signal strings

[Helge Deller]

On 19.11.19 20:56, Richard Henderson wrote:
> On 11/19/19 7:51 PM, Helge Deller wrote:
> > Add the textual representations of some missing target signals.
> >
> > Signed-off-by: Helge Deller <address@hidden>
> >
> > diff --git a/linux-user/strace.c b/linux-user/strace.c
> > index 3d4d684450..18b57a9ef9 100644
> > --- a/linux-user/strace.c
> > +++ b/linux-user/strace.c
> > @@ -146,6 +146,22 @@ print_signal(abi_ulong arg, int last)
> >       case TARGET_SIGSTOP: signal_name = "SIGSTOP"; break;
> >       case TARGET_SIGTTIN: signal_name = "SIGTTIN"; break;
> >       case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break;
> > +    case TARGET_SIGIO: signal_name = "SIGIO"; break;
> > +    case TARGET_SIGTRAP: signal_name = "SIGTRAP"; break;
> > +    /* case TARGET_SIGIOT: signal_name = "SIGIOT"; break; */
>
> Unused commented code.

True, but I kept it intentionally the same as it's currently in
linux-user/signal.c (line 40) so it's not forgotten if that changes:
/*    [SIGIOT] = TARGET_SIGIOT,*/

> > +#ifdef SIGSTKFLT
> > +    case TARGET_SIGSTKFLT: signal_name = "SIGSTKFLT"; break;
> > +#endif
>
> Wrong ifdef.

Same here, see in linux-user/signal.c (line 50):
#ifdef SIGSTKFLT
    [SIGSTKFLT] = TARGET_SIGSTKFLT,
#endif

Suggestions?

Helge