[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/16] kvm: introduce kvm_kernel_irqchip_* functions
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 15/16] kvm: introduce kvm_kernel_irqchip_* functions |
|
Date: |
Tue, 19 Nov 2019 13:13:31 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 19/11/19 12:56, Thomas Huth wrote:
>> - if (machine_kernel_irqchip_split(machine)) {
>> + if (kvm_enabled() && kvm_kernel_irqchip_split()) {
>> error_setg(errp, "kernel_irqchip split mode not supported on
>> pseries");
>> return;
>> }
> Any reason for the additional kvm_enabled() here? I think it should also
> be ok without that?
>
> Apart from that question, patch looks fine to me.
It won't compile without that, kvm_kernel_irqchip_split() is defined in
accel/kvm/kvm-all.c.
Paolo