Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards

[Laurent Vivier]

Hi,

thank you for your contribution.

I think we need some little changes:

- fix the errors reported by patchew (you can check your patch with
scripts/checkpatch.pl)

- split the patch in two parts: one to add the target, one to add the
linux-user part,

- add the license header in files where it is missing.
  (you can use the SPDX tag)

- I think you can remove the "DEBUG_HEX" in cpu_loop() as most of the
information can be displayed by QEMU_STRACE env variable. The one in
hexagon_tr_translate_packet() can be done using QEMU_SINGLESTEP (if I
understand the purpose),

- The "[__SIGRTMAX - 1] = __SIGRTMIN + 1" part must be in a separate
patch. As I said at KVM Forum, I agree with this change if it doesn't
break anything else but it can be controversial.

Thanks,
Laurent

Le 19/11/2019 à 00:58, Taylor Simpson a écrit :
> Signed-off-by: Taylor Simpson <address@hidden>
> ---
>  configure                                   |   9 +
>  default-configs/hexagon-linux-user.mak      |   1 +
>  include/elf.h                               |   2 +
>  linux-user/elfload.c                        |  16 ++
>  linux-user/hexagon/cpu_loop.c               | 103 +++++++++
>  linux-user/hexagon/signal.c                 | 276 +++++++++++++++++++++++
>  linux-user/hexagon/sockbits.h               |   3 +
>  linux-user/hexagon/syscall_nr.h             | 331 
> ++++++++++++++++++++++++++++
>  linux-user/hexagon/target_cpu.h             |  35 +++
>  linux-user/hexagon/target_elf.h             |  24 ++
>  linux-user/hexagon/target_fcntl.h           |   3 +
>  linux-user/hexagon/target_signal.h          |  19 ++
>  linux-user/hexagon/target_structs.h         |  31 +++
>  linux-user/hexagon/target_syscall.h         |  17 ++
>  linux-user/hexagon/termbits.h               | 231 +++++++++++++++++++
>  linux-user/signal.c                         |   8 +
>  linux-user/syscall.c                        |   2 +
>  linux-user/syscall_defs.h                   |  33 +++
>  target/hexagon/Makefile.objs                |   6 +
>  target/hexagon/cpu-param.h                  |  11 +
>  target/hexagon/cpu.c                        | 283 ++++++++++++++++++++++++
>  target/hexagon/cpu.h                        | 146 ++++++++++++
>  target/hexagon/cpu_bits.h                   |  15 ++
>  target/hexagon/helper.h                     |   3 +
>  target/hexagon/imported/global_types.h      |  25 +++
>  target/hexagon/imported/iss_ver_registers.h | 183 +++++++++++++++
>  target/hexagon/imported/max.h               |  78 +++++++
>  target/hexagon/imported/regs.h              |  19 ++
>  target/hexagon/op_helper.c                  |  29 +++
>  target/hexagon/translate.c                  | 220 ++++++++++++++++++
>  target/hexagon/translate.h                  |  22 ++
>  31 files changed, 2184 insertions(+)
>  create mode 100644 default-configs/hexagon-linux-user.mak
>  create mode 100644 linux-user/hexagon/cpu_loop.c
>  create mode 100644 linux-user/hexagon/signal.c
>  create mode 100644 linux-user/hexagon/sockbits.h
>  create mode 100644 linux-user/hexagon/syscall_nr.h
>  create mode 100644 linux-user/hexagon/target_cpu.h
>  create mode 100644 linux-user/hexagon/target_elf.h
>  create mode 100644 linux-user/hexagon/target_fcntl.h
>  create mode 100644 linux-user/hexagon/target_signal.h
>  create mode 100644 linux-user/hexagon/target_structs.h
>  create mode 100644 linux-user/hexagon/target_syscall.h
>  create mode 100644 linux-user/hexagon/termbits.h
>  create mode 100644 target/hexagon/Makefile.objs
>  create mode 100644 target/hexagon/cpu-param.h
>  create mode 100644 target/hexagon/cpu.c
>  create mode 100644 target/hexagon/cpu.h
>  create mode 100644 target/hexagon/cpu_bits.h
>  create mode 100644 target/hexagon/helper.h
>  create mode 100644 target/hexagon/imported/global_types.h
>  create mode 100644 target/hexagon/imported/iss_ver_registers.h
>  create mode 100644 target/hexagon/imported/max.h
>  create mode 100644 target/hexagon/imported/regs.h
>  create mode 100644 target/hexagon/op_helper.c
>  create mode 100644 target/hexagon/translate.c
>  create mode 100644 target/hexagon/translate.h
>