qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Implement backend program convention command for vhost-us


From: no-reply
Subject: Re: [PATCH v3] Implement backend program convention command for vhost-user-blk
Date: Mon, 18 Nov 2019 19:06:28 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v3] Implement backend program convention command for 
vhost-user-blk
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c1b5b56 Implement backend program convention command for vhost-user-blk

=== OUTPUT BEGIN ===
ERROR: suspect code indent for conditional statements (8, 11)
#92: FILE: contrib/vhost-user-blk/vhost-user-blk.c:630:
+        if (lsock < 0) {
+           exit(EXIT_FAILURE);

ERROR: space required before the open brace '{'
#95: FILE: contrib/vhost-user-blk/vhost-user-blk.c:633:
+    } else if(opt_fdnum < 0){

ERROR: space required before the open parenthesis '('
#95: FILE: contrib/vhost-user-blk/vhost-user-blk.c:633:
+    } else if(opt_fdnum < 0){

total: 3 errors, 0 warnings, 143 lines checked

Commit c1b5b56a6a0f (Implement backend program convention command for 
vhost-user-blk) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]