[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/6] Cleaned up flow of code in qemu_set_log(), to simplify an
From: |
Robert Foley |
Subject: |
[PATCH v3 2/6] Cleaned up flow of code in qemu_set_log(), to simplify and clarify. |
Date: |
Mon, 18 Nov 2019 16:15:24 -0500 |
Also added some explanation of the reasoning behind the branches.
Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
v2
- This is new in patch v2.
---
util/log.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/util/log.c b/util/log.c
index 4316fe74ee..417d16ec66 100644
--- a/util/log.c
+++ b/util/log.c
@@ -54,12 +54,25 @@ static bool log_uses_own_buffers;
/* enable or disable low levels log */
void qemu_set_log(int log_flags)
{
+ bool need_to_open_file = false;
qemu_loglevel = log_flags;
#ifdef CONFIG_TRACE_LOG
qemu_loglevel |= LOG_TRACE;
#endif
- if (!qemu_logfile &&
- (is_daemonized() ? logfilename != NULL : qemu_loglevel)) {
+ /*
+ * In all cases we only log if qemu_loglevel is set.
+ * Also:
+ * If not daemonized we will always log either to stderr
+ * or to a file (if there is a logfilename).
+ * If we are daemonized,
+ * we will only log if there is a logfilename.
+ */
+ if (qemu_loglevel && (!is_daemonized() || logfilename)) {
+ need_to_open_file = true;
+ }
+ if (qemu_logfile && !need_to_open_file) {
+ qemu_log_close();
+ } else if (!qemu_logfile && need_to_open_file) {
if (logfilename) {
qemu_logfile = fopen(logfilename, log_append ? "a" : "w");
if (!qemu_logfile) {
@@ -93,10 +106,6 @@ void qemu_set_log(int log_flags)
log_append = 1;
}
}
- if (qemu_logfile &&
- (is_daemonized() ? logfilename == NULL : !qemu_loglevel)) {
- qemu_log_close();
- }
}
void qemu_log_needs_buffers(void)
--
2.17.1
- [PATCH v3 0/6] Make the qemu_logfile handle thread safe., Robert Foley, 2019/11/18
- [PATCH v3 1/6] Fix double free issue in qemu_set_log_filename()., Robert Foley, 2019/11/18
- [PATCH v3 2/6] Cleaned up flow of code in qemu_set_log(), to simplify and clarify.,
Robert Foley <=
- [PATCH v3 3/6] Add a mutex to guarantee single writer to qemu_logfile handle., Robert Foley, 2019/11/18
- [PATCH v3 4/6] qemu_log_lock/unlock now preserves the qemu_logfile handle., Robert Foley, 2019/11/18
- [PATCH v3 5/6] Add use of RCU for qemu_logfile., Robert Foley, 2019/11/18
- [PATCH v3 6/6] Added tests for close and change of logfile., Robert Foley, 2019/11/18
- Re: [PATCH v3 0/6] Make the qemu_logfile handle thread safe., Alex Bennée, 2019/11/20