qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/16] vl: merge -accel processing into configure_accelerator


From: Paolo Bonzini
Subject: Re: [PATCH 03/16] vl: merge -accel processing into configure_accelerators
Date: Mon, 18 Nov 2019 12:39:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 18/11/19 12:27, Thomas Huth wrote:
>>       * Note: uses machine properties such as kernel-irqchip, must run
>>       * after machine_set_property().
>>       */
>> -    configure_accelerator(current_machine, argv[0]);
>> +    cpu_ticks_init();
>> +    configure_accelerators(argv[0]);
> The comment about kernel-irqchip obviously rather belongs to
> configure_accelerators() instead of cpu_ticks_init(), so maybe you
> should move the cpu_ticks_init() before the comment now?

Ok.

> (does it need
> to be moved here at all? ... it looks pretty independent at a first glance)

No, it doesn't.  Whether to move it or not is a matter of personal
preference, so I can certainly move it back.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]