[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip p
From: |
Greg Kurz |
Subject: |
Re: [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip pointer |
Date: |
Fri, 15 Nov 2019 13:45:52 +0100 |
On Fri, 15 Nov 2019 13:24:50 +0100
Cédric Le Goater <address@hidden> wrote:
> > diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> > index 55eee95104da..fce6d8d9b31b 100644
> > --- a/include/hw/ppc/pnv_core.h
> > +++ b/include/hw/ppc/pnv_core.h
> > @@ -36,11 +36,11 @@ typedef struct PnvChip PnvChip;
> > typedef struct PnvCore {
> > /*< private >*/
> > CPUCore parent_obj;
> > + PnvChip *chip;
> >
> > /*< public >*/
> > PowerPCCPU **threads;
> > uint32_t pir;
> > - PnvChip *chip;
> >
> > MemoryRegion xscom_regs;
> > } PnvCore;
> >
>
>
> Why this change ?
>
Because PnvCore::chip is an PnvCore internal that shouldn't be
used outside pnv_core.c IMHO.
> C.
- [PATCH for-5.0 0/8] ppc: Consolidate QOM links and pointers to the same object, Greg Kurz, 2019/11/15
- [PATCH for-5.0 2/8] xive: Link "xive" property to XiveSource::xive pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 1/8] xive: Link "cpu" property to XiveTCTX::cs pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 3/8] xive: Link "xive" property to XiveEndSource::xrtr pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 4/8] ppc/pnv: Link "psi" property to PnvLpc::psi pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 5/8] ppc/pnv: Link "psi" property to PnvOCC::psi pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 6/8] ppc/pnv: Link "chip" property to PnvHomer::chip pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip pointer, Greg Kurz, 2019/11/15
- [PATCH for-5.0 8/8] ppc/pnv: Link "chip" property to PnvXive::chip pointer, Greg Kurz, 2019/11/15
- Re: [PATCH for-5.0 0/8] ppc: Consolidate QOM links and pointers to the same object, Cédric Le Goater, 2019/11/15