[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct
From: |
Gerd Hoffmann |
Subject: |
Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct |
Date: |
Thu, 14 Nov 2019 08:20:42 +0100 |
User-agent: |
NeoMutt/20180716 |
On Wed, Nov 13, 2019 at 05:03:58PM +0200, Sam Eiderman wrote:
> Hi,
>
> Does this fix a bug that actually happened?
Yes, "make check-qtest" may fail. It's kind of random though.
> I just noticed that in my lchs patches I assumed that lchs struct is
> zeroed out in all devices (not only ahci):
ahci was the only one not zeroing out the struct (yes, I've reviewed
them all).
> Also Gerd it seems that my lchs patches were not committed in the
> latest submitted version (v4)!!!
Whoops. Can you sent a patch seabios/master ... v4 please?
IIRC there didn't change much, mostly the parser function, so that
should be alot less churn than a full revert + v4 reapply.
thanks,
Gerd
- [PATCH] ahci: zero-initialize port struct, Gerd Hoffmann, 2019/11/13
- Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct,
Gerd Hoffmann <=
- Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct, Sam Eiderman, 2019/11/14
- Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct, Gerd Hoffmann, 2019/11/15
- Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct, Gerd Hoffmann, 2019/11/15
- Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct, Sam Eiderman, 2019/11/15