Re: [PATCH] enable translating statx syscalls on more arches

[Laurent Vivier]

Le 13/11/2019 à 10:55, Aleksandar Markovic a écrit :
> 
> 
> On Tuesday, November 12, 2019, Andrew Kelley <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     ping
> 
> 
> 
> Hello, Andrew.
> 
> I just want to advise you to send, if possible, a new version of the
> patch, addressing whatt said in his review. It is better if you send it
> sooner rather than later, given the stage of our dev cycle.
> 
> For MIPS parts:
> 
> Reviewed-by: Aleksandar Markovic <address@hidden
> <mailto:address@hidden>>
> 

The i386 part breaks the build because it defines TARGET_NR_arch_prctl
and in linux-user/syscall.c we have:

    #ifdef TARGET_NR_arch_prctl
        case TARGET_NR_arch_prctl:
    #if defined(TARGET_I386) && !defined(TARGET_ABI32)
            return do_arch_prctl(cpu_env, arg1, arg2);
    #else
    #error unreachable
    #endif
    #endif

Thanks,
Laurent