[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 19/20] nvme: make lba data size configurable
|
From: |
Klaus Birkelund |
|
Subject: |
Re: [PATCH v2 19/20] nvme: make lba data size configurable |
|
Date: |
Wed, 13 Nov 2019 08:13:38 +0100 |
|
User-agent: |
Mutt/1.12.2 (2019-09-21) |
On Tue, Nov 12, 2019 at 03:24:00PM +0000, Beata Michalska wrote:
> Hi Klaus,
>
> On Tue, 15 Oct 2019 at 11:50, Klaus Jensen <address@hidden> wrote:
> > #define DEFINE_NVME_NS_PROPERTIES(_state, _props) \
> > - DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0)
> > + DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0), \
> > + DEFINE_PROP_UINT8("lbads", _state, _props.lbads, 9)
> >
> Could we actually use BDRV_SECTOR_BITS instead of magic numbers?
>
Yes, better. Fixed in two places.