[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/6] configure: Check bzip2 is available
From: |
Thomas Huth |
Subject: |
[PULL 6/6] configure: Check bzip2 is available |
Date: |
Tue, 12 Nov 2019 07:43:32 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
The bzip2 tool is not included in default installations.
On freshly installed systems, ./configure succeeds but 'make'
might fail later:
BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
/bin/sh: bzip2: command not found
make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127
make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd'
make: *** Waiting for unfinished jobs....
Add a check in ./configure to warn the user if bzip2 is missing.
See also: 536d2173b2b ("roms: build edk2 firmware binaries ...")
Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Luc Michel <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
configure | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index 9b322284c3..6099be1d84 100755
--- a/configure
+++ b/configure
@@ -2154,6 +2154,10 @@ for target in $target_list; do
;;
esac
done
+# The EDK2 binaries are compressed with bzip2
+if test "$edk2_blobs" = "yes" && ! has bzip2; then
+ error_exit "The bzip2 program is required for building QEMU"
+fi
feature_not_found() {
feature=$1
--
2.23.0
- [PULL 0/6] qtest and misc patches, Thomas Huth, 2019/11/12
- [PULL 2/6] cpu-plug-test: fix leaks, Thomas Huth, 2019/11/12
- [PULL 1/6] qtest: fix qtest_qmp_device_add leak, Thomas Huth, 2019/11/12
- [PULL 3/6] MAINTAINERS: slirp: Remove myself as maintainer, Thomas Huth, 2019/11/12
- [PULL 4/6] tests/migration: Print some debug on bad status, Thomas Huth, 2019/11/12
- [PULL 5/6] configure: Only decompress EDK2 blobs for X86/ARM targets, Thomas Huth, 2019/11/12
- [PULL 6/6] configure: Check bzip2 is available,
Thomas Huth <=
- Re: [PULL 0/6] qtest and misc patches, Peter Maydell, 2019/11/12