[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v5 022/126] backends/cryptodev: drop local_err from cryptodev_b
From: |
Marc-André Lureau |
Subject: |
Re: [RFC v5 022/126] backends/cryptodev: drop local_err from cryptodev_backend_complete() |
Date: |
Sat, 9 Nov 2019 00:59:07 +0400 |
On Fri, Oct 11, 2019 at 8:58 PM Vladimir Sementsov-Ogievskiy
<address@hidden> wrote:
>
> No reason for local_err here, use errp directly instead.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> backends/cryptodev.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/backends/cryptodev.c b/backends/cryptodev.c
> index 3c071eab95..5a9735684e 100644
> --- a/backends/cryptodev.c
> +++ b/backends/cryptodev.c
> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error
> **errp)
> {
> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
> - Error *local_err = NULL;
>
> if (bc->init) {
> - bc->init(backend, &local_err);
> - if (local_err) {
> - goto out;
> - }
> + bc->init(backend, errp);
> }
> -
> - return;
> -
> -out:
> - error_propagate(errp, local_err);
> }
>
> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
> --
> 2.21.0
>
>
Reviewed-by: Marc-André Lureau <address@hidden>
--
Marc-André Lureau
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC v5 022/126] backends/cryptodev: drop local_err from cryptodev_backend_complete(),
Marc-André Lureau <=