qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size


From: Palmer Dabbelt
Subject: Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size
Date: Thu, 07 Nov 2019 08:58:50 -0800 (PST)

On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote:
Coreboot developers have requested that they have at least 32MB of flash
to load binaries. We currently have 32MB of flash, but it is split in
two to allow loading two flash binaries. Let's increase the flash size
from 32MB to 64MB to ensure we have a single region that is 32MB.

No QEMU release has include flash in the RISC-V virt machine, so this
isn't a breaking change.

Even if we had, I wouldn't consider it a breaking change because it adds to the memory map so existing programs will continue to run fine.


Signed-off-by: Alistair Francis <address@hidden>
---
 hw/riscv/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index cc8f311e6b..23f340df19 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -62,7 +62,7 @@ static const struct MemmapEntry {
     [VIRT_PLIC] =        {  0xc000000,     0x4000000 },
     [VIRT_UART0] =       { 0x10000000,         0x100 },
     [VIRT_VIRTIO] =      { 0x10001000,        0x1000 },
-    [VIRT_FLASH] =       { 0x20000000,     0x2000000 },
+    [VIRT_FLASH] =       { 0x20000000,     0x4000000 },
     [VIRT_DRAM] =        { 0x80000000,           0x0 },
     [VIRT_PCIE_MMIO] =   { 0x40000000,    0x40000000 },
     [VIRT_PCIE_PIO] =    { 0x03000000,    0x00010000 },

Reviewed-by: Palmer Dabbelt <address@hidden>

I'll include this in my next PR, which should be soon -- I was about to send it, but figure I should look at my email first :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]