qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 08/20] tests: provide test variables to other targets


From: Darren Kenny
Subject: Re: [PATCH v4 08/20] tests: provide test variables to other targets
Date: Thu, 7 Nov 2019 14:32:37 +0000

On Wed, Oct 30, 2019 at 02:49:54PM +0000, Oleinik, Alexander wrote:
From: Alexander Oleinik <address@hidden>

Before, when tests/Makefile.include was included, the contents would be
ignored if config-host.mak was defined. Moving the ifneq responsible for
this allows a target to depend on both testing-related and host-related
objects. For example the virtual-device fuzzer relies on both
libqtest/libqos objects and softmmu objects.

Signed-off-by: Alexander Oleinik <address@hidden>

Reviewed-by: Darren Kenny <address@hidden>

---
tests/Makefile.include | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 34ec03391c..67853d10c3 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -27,7 +27,6 @@ check-help:
        @echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can 
be"
        @echo "changed with variable GTESTER_OPTIONS."

-ifneq ($(wildcard config-host.mak),)
export SRC_PATH

# TODO don't duplicate $(SRC_PATH)/Makefile's qapi-py here
@@ -873,6 +872,8 @@ tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y)

SPEED = quick

+ifneq ($(wildcard config-host.mak),)
+
# gtester tests, possibly with verbose output
# do_test_tap runs all tests, even if some of them fail, while do_test_human
# stops at the first failure unless -k is given on the command line
--
2.23.0





reply via email to

[Prev in Thread] Current Thread [Next in Thread]