[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 16/21] iotests: Make 091 work with data_file
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v2 16/21] iotests: Make 091 work with data_file |
Date: |
Wed, 06 Nov 2019 17:50:35 +0200 |
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote:
> The image end offset as reported by qemu-img check is different when
> using an external data file; we do not care about its value here, so we
> can just filter it. Incidentally, common.rc already has _check_test_img
> for us which does exactly that.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/091 | 2 +-
> tests/qemu-iotests/091.out | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
> index f4b44659ae..0874fa84c8 100755
> --- a/tests/qemu-iotests/091
> +++ b/tests/qemu-iotests/091
> @@ -101,7 +101,7 @@ echo "Check image pattern"
> ${QEMU_IO} -c "read -P 0x22 0 4M" "${TEST_IMG}" | _filter_testdir |
> _filter_qemu_io
>
> echo "Running 'qemu-img check -r all \$TEST_IMG'"
> -"${QEMU_IMG}" check -r all "${TEST_IMG}" 2>&1 | _filter_testdir |
> _filter_qemu
> +_check_test_img -r all
>
> echo "*** done"
> rm -f $seq.full
> diff --git a/tests/qemu-iotests/091.out b/tests/qemu-iotests/091.out
> index 5017f8c2d9..5ec7b00f13 100644
> --- a/tests/qemu-iotests/091.out
> +++ b/tests/qemu-iotests/091.out
> @@ -23,6 +23,4 @@ read 4194304/4194304 bytes at offset 0
> 4 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> Running 'qemu-img check -r all $TEST_IMG'
> No errors were found on the image.
> -80/16384 = 0.49% allocated, 0.00% fragmented, 0.00% compressed clusters
> -Image end offset: 5570560
> *** done
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 16/21] iotests: Make 091 work with data_file,
Maxim Levitsky <=