[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shm
From: |
Richard Henderson |
Subject: |
[PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat |
Date: |
Wed, 6 Nov 2019 12:33:08 +0100 |
The error indicator for this syscall is -1, not 0.
Fixes: e374bfa35bfb ("shm tests - disabled clone test")
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
tests/tcg/multiarch/linux-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index fa4243fc04..673d7c8a1c 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -503,8 +503,9 @@ static void test_shm(void)
shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
ptr = shmat(shmid, NULL, 0);
- if (!ptr)
+ if (ptr == (void *)-1) {
error("shmat");
+ }
memset(ptr, 0, SHM_SIZE);
--
2.17.1
- [PATCH v3 00/12] linux-user sparc fixes, Richard Henderson, 2019/11/06
- [PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat,
Richard Henderson <=
- [PATCH v3 01/12] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/11/06
- [PATCH v3 03/12] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/11/06
- [PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h, Richard Henderson, 2019/11/06
- [PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c, Richard Henderson, 2019/11/06
- [PATCH v3 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Richard Henderson, 2019/11/06
- [PATCH v3 07/12] linux-user/sparc: Fix WREG usage in setup_frame, Richard Henderson, 2019/11/06
- [PATCH v3 08/12] linux-user/sparc64: Fix target_signal_frame, Richard Henderson, 2019/11/06
- [PATCH v3 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child, Richard Henderson, 2019/11/06
- [PATCH v3 10/12] linux-user: Introduce cpu_clone_regs_parent, Richard Henderson, 2019/11/06
- [PATCH v3 11/12] linux-user/sparc: Fix cpu_clone_regs_*, Richard Henderson, 2019/11/06