[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide p
From: |
Eduardo Habkost |
Subject: |
Re: git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide patches) |
Date: |
Tue, 5 Nov 2019 16:38:20 -0300 |
On Thu, Oct 31, 2019 at 11:54:42AM -0400, John Snow wrote:
> On 10/31/19 11:02 AM, Peter Maydell wrote:
> > On Thu, 31 Oct 2019 at 10:59, John Snow <address@hidden> wrote:
> >>
> >> The following changes since commit
> >> 68d8ef4ec540682c3538d4963e836e43a211dd17:
> >>
> >> Merge remote-tracking branch
> >> 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30
> >> 14:10:32 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request
> >>
> >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c:
> >>
> >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400)
> >>
> >> ----------------------------------------------------------------
> >> Pull request
> >>
> >
> > Hi -- this passed the merge tests but it looks like you forgot
> > to add your signed-off by line as the submaintainer to Sam's
> > patches. Could you fix that up and resend, please?
> >
> > thanks
> > -- PMM
> >
>
> I bit myself twice with this now: adding --signoff to a pull request
> signs the messages that get sent to list, but not the ones that get staged.
>
> Could always be a bug in my local copy, but I'm documenting it on the
> list, in case I don't get time to look at this in the next 24h.
Reported on GitHub, so we don't forget to look at it:
https://github.com/stefanha/git-publish/issues/76
--
Eduardo
- Re: git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide patches),
Eduardo Habkost <=