[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h
From: |
Laurent Vivier |
Subject: |
[PULL 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h |
Date: |
Tue, 5 Nov 2019 19:11:11 +0100 |
From: Richard Henderson <address@hidden>
This fixes a naming bug wherein we used "UREG_FP" to access the
stack pointer. OTOH, the "UREG_FP" constant was also defined
incorrectly such that it *did* reference the stack pointer.
Note that the kernel legitimately uses the name "FP", because it
utilizes the rolled stack window in processing the system call.
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
linux-user/sparc/target_cpu.h | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
index 1ffc0ae9f2ec..b30fbc72c43b 100644
--- a/linux-user/sparc/target_cpu.h
+++ b/linux-user/sparc/target_cpu.h
@@ -41,15 +41,9 @@ static inline void cpu_set_tls(CPUSPARCState *env,
target_ulong newtls)
env->gregs[7] = newtls;
}
-#ifndef UREG_I6
-#define UREG_I6 6
-#endif
-#ifndef UREG_FP
-#define UREG_FP UREG_I6
-#endif
-
static inline abi_ulong get_sp_from_cpustate(CPUSPARCState *state)
{
- return state->regwptr[UREG_FP];
+ return state->regwptr[WREG_SP];
}
+
#endif
--
2.21.0
- [PULL 00/13] Linux user for 4.2 patches, Laurent Vivier, 2019/11/05
- [PULL 13/13] linux-user/alpha: Set r20 secondary return value, Laurent Vivier, 2019/11/05
- [PULL 01/13] linux-user: Support for NETLINK socket options, Laurent Vivier, 2019/11/05
- [PULL 10/13] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child, Laurent Vivier, 2019/11/05
- [PULL 07/13] linux-user/sparc: Use WREG_SP constant in sparc/signal.c, Laurent Vivier, 2019/11/05
- [PULL 02/13] scripts/qemu-binfmt-conf: Update for sparc64, Laurent Vivier, 2019/11/05
- [PULL 09/13] linux-user/sparc64: Fix target_signal_frame, Laurent Vivier, 2019/11/05
- [PULL 06/13] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Laurent Vivier, 2019/11/05
- [PULL 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h,
Laurent Vivier <=
- [PULL 04/13] target/sparc: Define an enumeration for accessing env->regwptr, Laurent Vivier, 2019/11/05
- [PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat, Laurent Vivier, 2019/11/05
- [PULL 12/13] linux-user/sparc: Fix cpu_clone_regs_*, Laurent Vivier, 2019/11/05
- [PULL 08/13] linux-user/sparc: Fix WREG usage in setup_frame, Laurent Vivier, 2019/11/05
- [PULL 11/13] linux-user: Introduce cpu_clone_regs_parent, Laurent Vivier, 2019/11/05
- Re: [PULL 00/13] Linux user for 4.2 patches, no-reply, 2019/11/05