qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] fdc/i8257: implement verify transfer mode


From: Hervé Poussineau
Subject: Re: [PATCH v3] fdc/i8257: implement verify transfer mode
Date: Sun, 3 Nov 2019 22:53:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

Le 01/11/2019 à 17:55, Sven Schnelle a écrit :
While working on the Tulip driver i tried to write some Teledisk images to
a floppy image which didn't work. Turned out that Teledisk checks the written
data by issuing a READ command to the FDC but running the DMA controller
in VERIFY mode. As we ignored the DMA request in that case, the DMA transfer
never finished, and Teledisk reported an error.

The i8257 spec says about verify transfers:

3) DMA verify, which does not actually involve the transfer of data. When an
8257 channel is in the DMA verify mode, it will respond the same as described
for transfer operations, except that no memory or I/O read/write control signals
will be generated.

Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more
clear boundary between DMA and FDC, so this patch also does that.

Suggested-by: Hervé Poussineau <address@hidden>
Signed-off-by: Sven Schnelle <address@hidden>
---
  hw/block/fdc.c       | 61 +++++++++++++-------------------------------
  hw/dma/i8257.c       | 20 ++++++++++-----
  include/hw/isa/isa.h |  1 -
  3 files changed, 31 insertions(+), 51 deletions(-)

Reviewed-by: Hervé Poussineau <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]