qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] remove unnecessary ifdef TARGET_RISCV64


From: Obinata Hiroyuki
Subject: Re: [PATCH] remove unnecessary ifdef TARGET_RISCV64
Date: Sat, 2 Nov 2019 10:16:45 +0900

Thanks!

2019年11月2日(土) 1:58 Palmer Dabbelt <address@hidden>:
On Tue, 29 Oct 2019 17:23:18 PDT (-0700), address@hidden wrote:
> From: "hiroyuki.obinata" <address@hidden>
>
> Signed-off-by: Hiroyuki Obinata <address@hidden>
> ---
>  target/riscv/translate.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index adeddb85f6..5c4dd21a98 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -64,12 +64,10 @@ static const int tcg_memop_lookup[8] = {
>      [0] = MO_SB,
>      [1] = MO_TESW,
>      [2] = MO_TESL,
> +    [3] = MO_TEQ,
>      [4] = MO_UB,
>      [5] = MO_TEUW,
> -#ifdef TARGET_RISCV64
> -    [3] = MO_TEQ,
>      [6] = MO_TEUL,
> -#endif
>  };
>  #endif

Reviewed-by: Palmer Dabbelt <address@hidden>

This is a non-functional change (the code in question was already wrapped in an
"#ifdef TARGET_RISCV64", so this internal one was redundant), so I'm happy to
include it during the soft freeze.

I've added this to the queue for my next PR.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]