Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX 
northbridge
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
3d1a8d2 hw/pci-host/i440fx: Remove the last PIIX3 traces
f2d285c hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'
93217a8 hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c
9b203e2 hw/pci-host/piix: Fix code style issues
708064b hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h
c9281a6 hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers
b2dc328 hw/pci-host/piix: Move RCR_IOPORT register definition
1fbf7c1 hw/pci-host/piix: Extract piix3_create()
9aa0091 hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers
504039e hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c
8b9938e hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()
a48fb41 hw/mips/mips_malta: Create IDE hard drive array dynamically
d352c6c piix4: Add a MC146818 RTC Controller as specified in datasheet
92da82e piix4: Add an i8254 PIT Controller as specified in datasheet
975e7c1 piix4: Add an i8257 DMA Controller as specified in datasheet
6709cb0 piix4: Rename PIIX4 object to piix4-isa
94ffa08 Revert "irq: introduce qemu_irq_proxy()"
6571bbc piix4: Add an i8259 Interrupt Controller as specified in datasheet
1ed0a87 piix4: Add the Reset Control Register
44ae66c MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

=== OUTPUT BEGIN ===
1/20 Checking commit 44ae66cabd2d (MAINTAINERS: Keep PIIX4 South Bridge 
separate from PC Chipsets)
2/20 Checking commit 1ed0a875993f (piix4: Add the Reset Control Register)
3/20 Checking commit 6571bbcb156c (piix4: Add an i8259 Interrupt Controller as 
specified in datasheet)
4/20 Checking commit 94ffa08f2346 (Revert "irq: introduce qemu_irq_proxy()")
5/20 Checking commit 6709cb03a51a (piix4: Rename PIIX4 object to piix4-isa)
6/20 Checking commit 975e7c1c1c5b (piix4: Add an i8257 DMA Controller as 
specified in datasheet)
7/20 Checking commit 92da82e20958 (piix4: Add an i8254 PIT Controller as 
specified in datasheet)
8/20 Checking commit d352c6ce2bdf (piix4: Add a MC146818 RTC Controller as 
specified in datasheet)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#193: 
deleted file mode 100644

total: 0 errors, 1 warnings, 166 lines checked

Patch 8/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/20 Checking commit a48fb41f3433 (hw/mips/mips_malta: Create IDE hard drive 
array dynamically)
10/20 Checking commit 8b9938e570c6 (hw/mips/mips_malta: Extract the PIIX4 
creation code as piix4_create())
11/20 Checking commit 504039e27e4d (hw/isa/piix4: Move piix4_create() to 
hw/isa/piix4.c)
12/20 Checking commit 9aa009158fb7 (hw/i386: Remove obsolete 
LoadStateHandler::load_state_old handlers)
13/20 Checking commit 1fbf7c155767 (hw/pci-host/piix: Extract piix3_create())
14/20 Checking commit b2dc3282a6bf (hw/pci-host/piix: Move RCR_IOPORT register 
definition)
15/20 Checking commit c9281a6fea29 (hw/pci-host/piix: Define and use the PIIX 
IRQ Route Control Registers)
16/20 Checking commit 708064b18db2 (hw/pci-host/piix: Move i440FX declarations 
to hw/pci-host/i440fx.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 16/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit 9b203e2aa380 (hw/pci-host/piix: Fix code style issues)
18/20 Checking commit 93217a8fd17d (hw/pci-host/piix: Extract PIIX3 functions 
to hw/isa/piix3.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#65: 
new file mode 100644

ERROR: spaces required around that '*' (ctx:VxV)
#314: FILE: hw/isa/piix3.c:245:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 1 warnings, 937 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/20 Checking commit f2d285ceef10 (hw/pci-host: Rename incorrectly named 
'piix' as 'i440fx')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
rename from hw/pci-host/piix.c

total: 0 errors, 1 warnings, 32 lines checked

Patch 19/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/20 Checking commit 3d1a8d21596f (hw/pci-host/i440fx: Remove the last PIIX3 
traces)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden