[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/16] Acceptance tests: refactor wait_for_console_pattern
From: |
Cleber Rosa |
Subject: |
[PULL 4/16] Acceptance tests: refactor wait_for_console_pattern |
Date: |
Mon, 28 Oct 2019 19:49:50 -0400 |
The same utility method is already present in two different test
files, so let's consolidate it into a single utility function.
Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
[PMD: failure_message is optional]
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>
---
tests/acceptance/avocado_qemu/__init__.py | 25 +++++++++++++++++++++
tests/acceptance/boot_linux_console.py | 27 +++++------------------
tests/acceptance/linux_ssh_mips_malta.py | 18 +++------------
3 files changed, 33 insertions(+), 37 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 711c29609a..772771e205 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -8,6 +8,7 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
+import logging
import os
import sys
import uuid
@@ -54,6 +55,30 @@ def pick_default_qemu_bin(arch=None):
return qemu_bin_from_src_dir_path
+def wait_for_console_pattern(test, success_message, failure_message=None):
+ """
+ Waits for messages to appear on the console, while logging the content
+
+ :param test: an Avocado test containing a VM that will have its console
+ read and probed for a success or failure message
+ :type test: :class:`avocado_qemu.Test`
+ :param success_message: if this message appears, test succeeds
+ :param failure_message: if this message appears, test fails
+ """
+ console = test.vm.console_socket.makefile()
+ console_logger = logging.getLogger('console')
+ while True:
+ msg = console.readline().strip()
+ if not msg:
+ continue
+ console_logger.debug(msg)
+ if success_message in msg:
+ break
+ if failure_message and failure_message in msg:
+ fail = 'Failure message found in console: %s' % failure_message
+ test.fail(fail)
+
+
class Test(avocado.Test):
def setUp(self):
self._vms = {}
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index 8a9a314ab4..8897e0c253 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -9,12 +9,12 @@
# later. See the COPYING file in the top-level directory.
import os
-import logging
import lzma
import gzip
import shutil
from avocado_qemu import Test
+from avocado_qemu import wait_for_console_pattern
from avocado.utils import process
from avocado.utils import archive
@@ -29,31 +29,14 @@ class BootLinuxConsole(Test):
KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
- def wait_for_console_pattern(self, success_message,
- failure_message='Kernel panic - not syncing'):
- """
- Waits for messages to appear on the console, while logging the content
-
- :param success_message: if this message appears, test succeeds
- :param failure_message: if this message appears, test fails
- """
- console = self.vm.console_socket.makefile()
- console_logger = logging.getLogger('console')
- while True:
- msg = console.readline().strip()
- if not msg:
- continue
- console_logger.debug(msg)
- if success_message in msg:
- break
- if failure_message in msg:
- fail = 'Failure message found in console: %s' % failure_message
- self.fail(fail)
+ def wait_for_console_pattern(self, success_message):
+ wait_for_console_pattern(self, success_message,
+ failure_message='Kernel panic - not syncing')
def exec_command_and_wait_for_pattern(self, command, success_message):
command += '\n'
self.vm.console_socket.sendall(command.encode())
- self.wait_for_console_pattern(success_message)
+ wait_for_console_pattern(self, success_message)
def extract_from_deb(self, deb, path):
"""
diff --git a/tests/acceptance/linux_ssh_mips_malta.py
b/tests/acceptance/linux_ssh_mips_malta.py
index aa12001942..fc13f9e4d4 100644
--- a/tests/acceptance/linux_ssh_mips_malta.py
+++ b/tests/acceptance/linux_ssh_mips_malta.py
@@ -13,6 +13,7 @@ import time
from avocado import skipUnless
from avocado_qemu import Test
+from avocado_qemu import wait_for_console_pattern
from avocado.utils import process
from avocado.utils import archive
from avocado.utils import ssh
@@ -69,19 +70,6 @@ class LinuxSSH(Test):
def setUp(self):
super(LinuxSSH, self).setUp()
- def wait_for_console_pattern(self, success_message,
- failure_message='Oops'):
- console = self.vm.console_socket.makefile()
- console_logger = logging.getLogger('console')
- while True:
- msg = console.readline()
- console_logger.debug(msg.strip())
- if success_message in msg:
- break
- if failure_message in msg:
- fail = 'Failure message found in console: %s' % failure_message
- self.fail(fail)
-
def get_portfwd(self):
res = self.vm.command('human-monitor-command',
command_line='info usernet')
@@ -137,7 +125,7 @@ class LinuxSSH(Test):
self.log.info('VM launched, waiting for sshd')
console_pattern = 'Starting OpenBSD Secure Shell server: sshd'
- self.wait_for_console_pattern(console_pattern)
+ wait_for_console_pattern(self, console_pattern, 'Oops')
self.log.info('sshd ready')
self.ssh_connect('root', 'root')
@@ -145,7 +133,7 @@ class LinuxSSH(Test):
def shutdown_via_ssh(self):
self.ssh_command('poweroff')
self.ssh_disconnect_vm()
- self.wait_for_console_pattern('Power down')
+ wait_for_console_pattern(self, 'Power down', 'Oops')
def ssh_command_output_contains(self, cmd, exp):
stdout, _ = self.ssh_command(cmd)
--
2.21.0
- [PULL 0/16] Python (acceptance tests) queue, 2019-10-28, Cleber Rosa, 2019/10/28
- [PULL 13/16] tests/boot_linux_console: Use Avocado archive::gzip_uncompress(), Cleber Rosa, 2019/10/28
- [PULL 14/16] tests/boot_linux_console: Add a test for the Raspberry Pi 2, Cleber Rosa, 2019/10/28
- [PULL 12/16] .travis.yml: Let the avocado job run the 40p tests, Cleber Rosa, 2019/10/28
- [PULL 11/16] tests/acceptance: Test OpenBIOS on the PReP/40p, Cleber Rosa, 2019/10/28
- [PULL 10/16] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p, Cleber Rosa, 2019/10/28
- [PULL 9/16] .travis.yml: Let the avocado job run the Leon3 test, Cleber Rosa, 2019/10/28
- [PULL 8/16] tests/acceptance: Add test that boots the HelenOS microkernel on Leon3, Cleber Rosa, 2019/10/28
- [PULL 6/16] tests/acceptance: Send <carriage return> on serial lines, Cleber Rosa, 2019/10/28
- [PULL 4/16] Acceptance tests: refactor wait_for_console_pattern,
Cleber Rosa <=
- [PULL 7/16] tests/acceptance: Refactor exec_command_and_wait_for_pattern(), Cleber Rosa, 2019/10/28
- [PULL 15/16] tests/boot_linux_console: Add initrd test for the Exynos4210, Cleber Rosa, 2019/10/28
- [PULL 1/16] MAINTAINERS: update location of Python libraries, Cleber Rosa, 2019/10/28
- [PULL 5/16] tests/acceptance: Fix wait_for_console_pattern() hangs, Cleber Rosa, 2019/10/28
- [PULL 2/16] Acceptance tests: work around socket dir, Cleber Rosa, 2019/10/28
- [PULL 3/16] Python libs: close console sockets before shutting down the VMs, Cleber Rosa, 2019/10/28
- [PULL 16/16] tests/boot_linux_console: Run BusyBox on 5KEc 64-bit cpu, Cleber Rosa, 2019/10/28
- Re: [PULL 0/16] Python (acceptance tests) queue, 2019-10-28, Peter Maydell, 2019/10/29