[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 08/12] exec: Promote TARGET_PAGE_MASK to target_long
From: |
Richard Henderson |
Subject: |
[PULL v2 08/12] exec: Promote TARGET_PAGE_MASK to target_long |
Date: |
Mon, 28 Oct 2019 15:59:33 +0100 |
There are some uint64_t uses that expect TARGET_PAGE_MASK to
extend for a 32-bit, so this must continue to be a signed type.
Define based on TARGET_PAGE_BITS not TARGET_PAGE_SIZE; this
will make a following patch more clear.
This should not have a functional effect so far.
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
include/exec/cpu-all.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index 525059970c..0543359d0f 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -229,7 +229,7 @@ extern TargetPageBits target_page;
#endif
#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
-#define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
+#define TARGET_PAGE_MASK ((target_long)-1 << TARGET_PAGE_BITS)
#define TARGET_PAGE_ALIGN(addr) ROUND_UP((addr), TARGET_PAGE_SIZE)
/* Using intptr_t ensures that qemu_*_page_mask is sign-extended even
--
2.17.1
- [PULL v2 00/12] tcg patch queue, Richard Henderson, 2019/10/28
- [PULL v2 02/12] cputlb: ensure _cmmu helper functions follow the naming standard, Richard Henderson, 2019/10/28
- [PULL v2 04/12] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/10/28
- [PULL v2 05/12] configure: Detect compiler support for __attribute__((alias)), Richard Henderson, 2019/10/28
- [PULL v2 08/12] exec: Promote TARGET_PAGE_MASK to target_long,
Richard Henderson <=
- [PULL v2 09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 10/12] cputlb: Fix tlb_vaddr_to_host, Richard Henderson, 2019/10/28
- [PULL v2 01/12] tci: Add implementation for INDEX_op_ld16u_i64, Richard Henderson, 2019/10/28
- [PULL v2 03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN, Richard Henderson, 2019/10/28
- [PULL v2 06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 12/12] translate-all: Remove tb_alloc, Richard Henderson, 2019/10/28
- [PULL v2 07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/10/28
- [PULL v2 11/12] translate-all: fix uninitialized tb->orig_tb, Richard Henderson, 2019/10/28
- Re: [PULL v2 00/12] tcg patch queue, no-reply, 2019/10/28
- Re: [PULL v2 00/12] tcg patch queue, Peter Maydell, 2019/10/29