[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh |
Date: |
Fri, 25 Oct 2019 16:01:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 22/10/19 13:17, Laurent Vivier wrote:
> + if (s->dma_memory_read) {
> + s->dma_memory_read(s->dma_opaque, &s->cmdbuf[s->cmdlen], len);
> + } else {
> + set_pdma(s, CMD, s->cmdlen, len);
> + s->pdma_cb = do_dma_pdma_cb;
> + esp_raise_drq(s);
> + return;
> + }
> + trace_esp_handle_ti_cmd(s->cmdlen);
> + s->ti_size = 0;
> + s->cmdlen = 0;
> + s->do_cmd = 0;
> + do_cmd(s, s->cmdbuf);
> return;
Can you explain these lines after s->dma_memory_read? I suppose they
are related to
> - }
> - if (s->do_cmd) {
> + } else if (s->do_cmd) {
If so, it would be nice to make those a separate patch. Otherwise seems
okay.
Paolo
- [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, Laurent Vivier, 2019/10/22
- [PATCH v14 2/9] dp8393x: manage big endian bus, Laurent Vivier, 2019/10/22
- [PATCH v14 9/9] BootLinuxConsoleTest: Test the Quadra 800, Laurent Vivier, 2019/10/22
- [PATCH v14 5/9] hw/m68k: add Nubus support, Laurent Vivier, 2019/10/22
- [PATCH v14 6/9] hw/m68k: add Nubus macfb video card, Laurent Vivier, 2019/10/22
- [PATCH v14 8/9] hw/m68k: define Macintosh Quadra 800, Laurent Vivier, 2019/10/22
- [PATCH v14 7/9] hw/m68k: add a dummy SWIM floppy controller, Laurent Vivier, 2019/10/22
- Re: [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, no-reply, 2019/10/22