Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [RFC v4 PATCH 00/49] Initial support of multi-process qemu
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
75d605b multi-process: add configure and usage information
1724569 multi-process: add the concept description to 
docs/devel/qemu-multiprocess
15328b7 multi-process: Enable support for multiple devices in remote
5cf79267 multi-process/mig: Restore the VMSD in remote process
97c15c9 multi-process/mig: Synchronize runstate of remote process
1b67b17 multi-process/mig: refactor runstate_check into common file
55e4b53 multi-process/mig: Load VMSD in the proxy object
7e1b819 multi-process/mig: Send VMSD of remote to the Proxy object
399f9bf multi-process/mig: Enable VMSD save in the Proxy object
645fc27 multi-process/mig: build migration module in the remote process
f0265a7 multi-process: prevent duplicate memory initialization in remote
a0faf9e multi-process/mon: Initialize QMP module for remote processes
58310d9 multi-process/mon: Refactor monitor/chardev functions out of vl.c
ae4fd02 multi-process/mon: enable QMP module support in the remote process
d7e2191 multi-process/mon: stub functions to enable QMP module for remote 
process
2c67c85 multi-process/mon: choose HMP commands based on target
cb5ab3e multi-process: perform device reset in the remote process
3214409 multi-process: Use separate MMIO communication channel
c34c47f multi-process: handle heartbeat messages in remote process
ccd9230 multi-process: send heartbeat messages to remote
f4991d6 multi-process: add parse_cmdline in remote process
a90d6c6 multi-process: add remote options parser
d616c9d multi-process: add remote option
45c18dd multi-process: refractor vl.c code to re-use in remote
57b6105 multi-process: Introduce build flags to separate remote process code
1295409 multi-process: add processing of remote drive and device command line
e876f72 multi-process: remote: add create_done condition
effa3f0 multi-process: remote: use fd for socket from parent process
de69c89 multi-process: remote: add setup_devices and setup_drive msg processing
afc658d multi-process: add qdev_proxy_add to create proxy devices
70e0f47 multi-process: configure remote side devices
701a141 multi-process: create IOHUB object to handle irq
613c372 multi-process: Synchronize remote memory
f5183a9 multi-process: Add LSI device proxy object
7778ec0 multi-process: PCI BAR read/write handling for proxy & remote endpoints
736d74d mutli-process: build remote command line args
650f3d1 multi-process: introduce proxy object
9374d1a multi-process: remote process initialization
1965b18 multi-process: setup memory manager for remote device
719f823 multi-process: setup a machine object for remote device process
59bdda6 multi-process: setup PCI host bridge for remote device
139cdee multi-process: add functions to synchronize proxy and remote endpoints
1b3c1f0 multi-process: define mpqemu-link object
ac130ca multi-process: build system for remote device process
93774c4 multi-process: Add config option for multi-process QEMU
7e5f9b2 multi-process: Add stub functions to facilate build of multi-process
73740e6 multi-process: add a command line option for debug file
59f2f7d multi-process: util: Add qemu_thread_cancel() to cancel running thread
18b29a1 multi-process: memory: alloc RAM from file at offset

=== OUTPUT BEGIN ===
1/49 Checking commit 18b29a1306b2 (multi-process: memory: alloc RAM from file 
at offset)
2/49 Checking commit 59f2f7d24d20 (multi-process: util: Add 
qemu_thread_cancel() to cancel running thread)
3/49 Checking commit 73740e6eff21 (multi-process: add a command line option for 
debug file)
4/49 Checking commit 7e5f9b26d48c (multi-process: Add stub functions to 
facilate build of multi-process)
ERROR: suspect code indent for conditional statements (4, 4)
#137: FILE: accel/stubs/tcg-stub.c:109:
+    while (1) {
+    }

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#151: 
new file mode 100644

total: 1 errors, 1 warnings, 376 lines checked

Patch 4/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/49 Checking commit 93774c4a2c28 (multi-process: Add config option for 
multi-process QEMU)
6/49 Checking commit ac130ca326fe (multi-process: build system for remote 
device process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#286: 
new file mode 100644

total: 0 errors, 1 warnings, 244 lines checked

Patch 6/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/49 Checking commit 1b3c1f0e0495 (multi-process: define mpqemu-link object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

WARNING: line over 80 characters
#171: FILE: include/io/mpqemu-link.h:147:
+void mpqemu_link_set_callback(MPQemuLinkState *s, mpqemu_link_callback 
callback);

WARNING: line over 80 characters
#397: FILE: io/mpqemu-link.c:207:
+                qemu_log_mask(LOG_REMOTE_DEBUG, "%s: Max FDs exceeded\n", 
__func__);

total: 0 errors, 3 warnings, 464 lines checked

Patch 7/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/49 Checking commit 139cdee6cbf6 (multi-process: add functions to synchronize 
proxy and remote endpoints)
9/49 Checking commit 59bdda61a183 (multi-process: setup PCI host bridge for 
remote device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 153 lines checked

Patch 9/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/49 Checking commit 719f82346cb6 (multi-process: setup a machine object for 
remote device process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 207 lines checked

Patch 10/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/49 Checking commit 1965b18cc69e (multi-process: setup memory manager for 
remote device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#81: 
new file mode 100644

total: 0 errors, 1 warnings, 182 lines checked

Patch 11/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/49 Checking commit 9374d1ad3f30 (multi-process: remote process 
initialization)
13/49 Checking commit 650f3d106d82 (multi-process: introduce proxy object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 379 lines checked

Patch 13/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/49 Checking commit 736d74d6623b (mutli-process: build remote command line 
args)
WARNING: line over 80 characters
#141: FILE: hw/proxy/qemu-proxy.c:243:
+static void init_proxy(PCIDevice *dev, char *command, bool need_spawn, Error 
**errp)

WARNING: line over 80 characters
#167: FILE: include/hw/proxy/qemu-proxy.h:66:
+    void (*init_proxy) (PCIDevice *dev, char *command, bool need_spawn, Error 
**errp);

total: 0 errors, 2 warnings, 146 lines checked

Patch 14/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/49 Checking commit 7778ec04e0e6 (multi-process: PCI BAR read/write handling 
for proxy & remote endpoints)
16/49 Checking commit f5183a9f01b5 (multi-process: Add LSI device proxy object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 135 lines checked

Patch 16/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/49 Checking commit 613c372a8221 (multi-process: Synchronize remote memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 344 lines checked

Patch 17/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/49 Checking commit 701a141ec1a3 (multi-process: create IOHUB object to 
handle irq)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#202: 
new file mode 100644

total: 0 errors, 1 warnings, 435 lines checked

Patch 18/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/49 Checking commit 70e0f47f0652 (multi-process: configure remote side 
devices)
20/49 Checking commit afc658d34c34 (multi-process: add qdev_proxy_add to create 
proxy devices)
21/49 Checking commit de69c899ae12 (multi-process: remote: add setup_devices 
and setup_drive msg processing)
22/49 Checking commit effa3f06a627 (multi-process: remote: use fd for socket 
from parent process)
23/49 Checking commit e876f72db9ae (multi-process: remote: add create_done 
condition)
24/49 Checking commit 129540993d75 (multi-process: add processing of remote 
drive and device command line)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: vl.c:1149:
+    dev = qdev_remote_add(opts, false /* this is drive */, errp);

WARNING: Block comments use a leading /* on a separate line
#87: FILE: vl.c:2246:
+    dev = qdev_remote_add(opts, true /* this is device */, errp);

WARNING: line over 80 characters
#121: FILE: vl.c:4418:
+     * need PCI host initialized. As a TODO: could defer init of PCIProxyDev 
instead.

total: 0 errors, 3 warnings, 117 lines checked

Patch 24/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/49 Checking commit 57b61051819d (multi-process: Introduce build flags to 
separate remote process code)
26/49 Checking commit 45c18ddb523b (multi-process: refractor vl.c code to 
re-use in remote)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#157: FILE: vl-parse.c:118:
+    dev = qdev_remote_add(opts, false /* this is drive */, errp);

WARNING: Block comments use a leading /* on a separate line
#172: FILE: vl-parse.c:133:
+    dev = qdev_remote_add(opts, true /* this is device */, errp);

total: 0 errors, 3 warnings, 412 lines checked

Patch 26/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/49 Checking commit d616c9d52b3e (multi-process: add remote option)
28/49 Checking commit a90d6c6eebff (multi-process: add remote options parser)
WARNING: Block comments use a leading /* on a separate line
#37: FILE: vl.c:300:
+        { /* end of list */ }

total: 0 errors, 1 warnings, 147 lines checked

Patch 28/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/49 Checking commit f4991d61c243 (multi-process: add parse_cmdline in remote 
process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

ERROR: line over 90 characters
#151: FILE: remote/remote-opts.c:88:
+                error_report("Option not supported for this target, %x 
arch_mask, %x arch_type",

total: 1 errors, 1 warnings, 180 lines checked

Patch 29/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

30/49 Checking commit ccd92304b77d (multi-process: send heartbeat messages to 
remote)
31/49 Checking commit c34c47ff9925 (multi-process: handle heartbeat messages in 
remote process)
32/49 Checking commit 32144092e7eb (multi-process: Use separate MMIO 
communication channel)
33/49 Checking commit cb5ab3eb7d63 (multi-process: perform device reset in the 
remote process)
34/49 Checking commit 2c67c85818aa (multi-process/mon: choose HMP commands 
based on target)
35/49 Checking commit d7e21910a6c4 (multi-process/mon: stub functions to enable 
QMP module for remote process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#108: 
new file mode 100644

total: 0 errors, 1 warnings, 722 lines checked

Patch 35/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/49 Checking commit ae4fd022fa7e (multi-process/mon: enable QMP module 
support in the remote process)
37/49 Checking commit 58310d9c635b (multi-process/mon: Refactor monitor/chardev 
functions out of vl.c)
38/49 Checking commit a0faf9ea04b0 (multi-process/mon: Initialize QMP module 
for remote processes)
39/49 Checking commit f0265a76742b (multi-process: prevent duplicate memory 
initialization in remote)
40/49 Checking commit 645fc2738aec (multi-process/mig: build migration module 
in the remote process)
41/49 Checking commit 399f9bf4ba56 (multi-process/mig: Enable VMSD save in the 
Proxy object)
ERROR: suspect code indent for conditional statements (4, 4)
#126: FILE: hw/proxy/qemu-proxy.c:449:
+    while (*((volatile uint64_t *)&pdev->migsize) < size) {
+    }

total: 1 errors, 0 warnings, 173 lines checked

Patch 41/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

42/49 Checking commit 7e1b8192f562 (multi-process/mig: Send VMSD of remote to 
the Proxy object)
43/49 Checking commit 55e4b53ec008 (multi-process/mig: Load VMSD in the proxy 
object)
44/49 Checking commit 1b67b1722798 (multi-process/mig: refactor runstate_check 
into common file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 92 lines checked

Patch 44/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
45/49 Checking commit 97c15c99f41f (multi-process/mig: Synchronize runstate of 
remote process)
46/49 Checking commit 5cf792672396 (multi-process/mig: Restore the VMSD in 
remote process)
ERROR: that open brace { should be on the previous line
#118: FILE: remote/remote-main.c:527:
+        if (process_start_mig_in(msg))
+        {

total: 1 errors, 0 warnings, 103 lines checked

Patch 46/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

47/49 Checking commit 15328b7aae2d (multi-process: Enable support for multiple 
devices in remote)
48/49 Checking commit 1724569b4d71 (multi-process: add the concept description 
to docs/devel/qemu-multiprocess)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 1106 lines checked

Patch 48/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/49 Checking commit 75d605b31739 (multi-process: add configure and usage 
information)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 86 lines checked

Patch 49/49 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden