[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 35/39] audio: fix missing break
From: |
Paolo Bonzini |
Subject: |
Re: [PULL 35/39] audio: fix missing break |
Date: |
Thu, 24 Oct 2019 18:02:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 24/10/19 17:14, Philippe Mathieu-Daudé wrote:
> On 10/24/19 4:03 PM, Paolo Bonzini wrote:
>> Reported by Coverity (CID 1406449).
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> I reviewed this one.
Oops, sorry. I must have lost your R-b when moving the patch from one
computer to the other.
Paolo
>> ---
>> audio/paaudio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/audio/paaudio.c b/audio/paaudio.c
>> index df541a7..55a91f8 100644
>> --- a/audio/paaudio.c
>> +++ b/audio/paaudio.c
>> @@ -385,6 +385,7 @@ static pa_stream *qpa_simple_new (
>> map.map[5] = PA_CHANNEL_POSITION_REAR_RIGHT;
>> map.map[6] = PA_CHANNEL_POSITION_SIDE_LEFT;
>> map.map[7] = PA_CHANNEL_POSITION_SIDE_RIGHT;
>> + break;
>> default:
>> dolog("Internal error: unsupported channel count %d\n",
>> ss->channels);
>>
- [PULL 30/39] hw/i386/pc: Remove kvm_i386.h include, (continued)
- [PULL 30/39] hw/i386/pc: Remove kvm_i386.h include, Paolo Bonzini, 2019/10/24
- [PULL 32/39] mc146818rtc: Move RTC_ISA_IRQ definition, Paolo Bonzini, 2019/10/24
- [PULL 25/39] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE, Paolo Bonzini, 2019/10/24
- [PULL 29/39] hw/i386/pc: Extract pc_i8259_create(), Paolo Bonzini, 2019/10/24
- [PULL 33/39] mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.c, Paolo Bonzini, 2019/10/24
- [PULL 13/39] hw/i386/pc: move shared x86 functions to x86.c and export them, Paolo Bonzini, 2019/10/24
- [PULL 27/39] hw/i386/pc: Extract pc_gsi_create(), Paolo Bonzini, 2019/10/24
- [PULL 31/39] mc146818rtc: move structure to header file, Paolo Bonzini, 2019/10/24
- [PULL 35/39] audio: fix missing break, Paolo Bonzini, 2019/10/24
- [PULL 38/39] target/i386: introduce cpu_set_fpus, Paolo Bonzini, 2019/10/24
- [PULL 37/39] target/i386: move FERR handling to target/i386, Paolo Bonzini, 2019/10/24
- [PULL 34/39] mc146818rtc: always register rtc to rtc list, Paolo Bonzini, 2019/10/24
- [PULL 39/39] i386: implement IGNNE, Paolo Bonzini, 2019/10/24
- [PULL 36/39] core: replace getpagesize() with qemu_real_host_page_size, Paolo Bonzini, 2019/10/24
- Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24, no-reply, 2019/10/25
- Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24, Peter Maydell, 2019/10/25