Re: [PATCH 00/30] virtiofs daemon (base)

[Dr. David Alan Gilbert]

* Michael S. Tsirkin (address@hidden) wrote:
> On Mon, Oct 21, 2019 at 03:33:57PM +0100, Dr. David Alan Gilbert wrote:
> > * address@hidden (address@hidden) wrote:
> > > Patchew URL: https://patchew.org/QEMU/address@hidden/
> > > 
> > > 
> > > 
> > > Hi,
> > > 
> > > This series seems to have some coding style problems. See output below for
> > > more information:
> > > 
> > > Subject: [PATCH 00/30] virtiofs daemon (base)
> > > Type: series
> > > Message-id: address@hidden
> > > 
> > > === TEST SCRIPT BEGIN ===
> > > #!/bin/bash
> > > git rev-parse base > /dev/null || exit 0
> > > git config --local diff.renamelimit 0
> > > git config --local diff.renames True
> > > git config --local diff.algorithm histogram
> > > ./scripts/checkpatch.pl --mailback base..
> > 
> > Expecting checkpatch to be broken here; most of the files
> > follow FUSE's formatting.
> > 
> > Dave
> 
> I wonder what do others think about this.
> One problem with such inconsistencies is that people tend to copy code
> around, which tends to result in a mess.

Converting them is not entirely trivial; so shout now if you'd like it!
I've got an evil combination of indent and clang-tidy that does a
reasonablish job of getting close to qemu's coding standard - but it
does need some hand holding; so is a few days work.
(I applied it to fuse_virtio.c which had a mix of styles).

Dave

> > --
> > Dr. David Alan Gilbert / address@hidden / Manchester, UK
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK