[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build |
Date: |
Thu, 24 Oct 2019 11:54:59 +0100 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Peter Maydell <address@hidden> writes:
> On Tue, 22 Oct 2019 at 20:20, Alex Bennée <address@hidden> wrote:
>>
>> The MacOS build can time out on Cirrus running to almost an hour.
>> Reduce the scope to the historical MacOS architectures much the same
>> way we do on Travis.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> .cirrus.yml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/.cirrus.yml b/.cirrus.yml
>> index 8326a3a4b16..4b042c0e12c 100644
>> --- a/.cirrus.yml
>> +++ b/.cirrus.yml
>> @@ -1,5 +1,6 @@
>> env:
>> CIRRUS_CLONE_DEPTH: 1
>> + MACOS_ARCHES:
>> i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu
>
> I don't know whether Cirrus is our long-term plan for doing
> CI of OSX (maybe we'll be using Gitlab and some runner on an
> OSX platform??), but as a general point: since OSX is one of
> the non-Linux hosts it's therefore worth making sure our
> compile-coverage is as wide as possible, not narrow. It's
> safe(r) to have narrow coverage of x86-Linux because people
> catch issues with that anyway, but it's exactly the less
> common platforms like OSX, the BSDs, odd architectures that
> we want to be compile/make-check testing as much of our code
> as possible.
OK I can drop the patch. It seems the long builds are just a random
pause that occasionally happens on their MacOS host.
>
> thanks
> -- PMM
--
Alex Bennée
- [PATCH v1 11/19] tests/vm: Let subclasses disable IPv6, (continued)
- [PATCH v1 11/19] tests/vm: Let subclasses disable IPv6, Alex Bennée, 2019/10/22
- [PATCH v1 06/19] travis.yml: Test the release tarball, Alex Bennée, 2019/10/22
- [PATCH v1 04/19] travis.yml: Use newer version of libgnutls and libpng, Alex Bennée, 2019/10/22
- [PATCH v1 09/19] cirrus.yml: add latest Xcode build target, Alex Bennée, 2019/10/22
- [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build, Alex Bennée, 2019/10/22
- Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build, Peter Maydell, 2019/10/24
- [PATCH v1 08/19] travis.yml: bump Xcode 10 to latest dot release, Alex Bennée, 2019/10/22
- [PATCH v1 05/19] travis.yml: Fix the ccache lines, Alex Bennée, 2019/10/22
- [PATCH v1 13/19] travis.yml: cache the clang sanitizer build, Alex Bennée, 2019/10/22
- [PATCH v1 10/19] tests/vm: netbsd autoinstall, using serial console, Alex Bennée, 2019/10/22
- [PATCH v1 14/19] iotests: remove 'linux' from default supported platforms, Alex Bennée, 2019/10/22
- [PATCH v1 15/19] iotests: Test 041 only works on certain systems, Alex Bennée, 2019/10/22