qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] nvme: fix NSSRS offset in CAP register


From: Klaus Birkelund
Subject: Re: [PATCH] nvme: fix NSSRS offset in CAP register
Date: Wed, 23 Oct 2019 21:55:05 +0200
User-agent: Mutt/1.12.2 (2019-09-21)

On Wed, Oct 23, 2019 at 11:26:57AM -0400, John Snow wrote:
> 
> 
> On 10/23/19 3:33 AM, Klaus Jensen wrote:
> > Fix the offset of the NSSRS field the CAP register.
> 
> From NVME 1.4, section 3 ("Controller Registers"), subsection 3.1.1
> ("Offset 0h: CAP – Controller Capabilities") CAP_NSSRS_SHIFT is bit 36,
> not 33.
> 
> > 
> > Signed-off-by: Klaus Jensen <address@hidden>
> > Reported-by: Javier Gonzalez <address@hidden>
> > ---
> >  include/block/nvme.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/block/nvme.h b/include/block/nvme.h
> > index 3ec8efcc435e..fa15b51c33bb 100644
> > --- a/include/block/nvme.h
> > +++ b/include/block/nvme.h
> > @@ -23,7 +23,7 @@ enum NvmeCapShift {
> >      CAP_AMS_SHIFT      = 17,
> >      CAP_TO_SHIFT       = 24,
> >      CAP_DSTRD_SHIFT    = 32,
> > -    CAP_NSSRS_SHIFT    = 33,
> > +    CAP_NSSRS_SHIFT    = 36,
> >      CAP_CSS_SHIFT      = 37,
> >      CAP_MPSMIN_SHIFT   = 48,
> >      CAP_MPSMAX_SHIFT   = 52,
> > 
> 
> I like updating commit messages with spec references; if it can be
> updated that would be nice.
> 
> Regardless:
> 
> Reviewed-by: John Snow <address@hidden>
> 

Sounds good. Can the committer squash that in?


Cheers,
Klaus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]