[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step |
Date: |
Wed, 23 Oct 2019 07:04:49 -0400 (EDT) |
----- Original Message -----
> From: "Stefan Hajnoczi" <address@hidden>
> Sent: Wednesday, October 23, 2019 12:04:17 PM
>
> Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK
> status bit is set to indicate that feature negotiation has completed.
> The driver then reads the status register again to check that the device
> agrees with the final features.
>
> Implement this step as part of qvirtio_set_features() instead of
> introducing a separate function. This way all existing code works
> without modifications.
>
> The check in qvirtio_set_driver_ok() needs to be updated because
> FEATURES_OK will be set for VIRTIO 1.0 devices.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> v4:
> * Make FEATURES_OK change in qvirtio_set_driver_ok() clearer and
> mention it in the commit description [Thomas]
> ---
> tests/libqos/virtio.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth" <address@hidden>
- [PATCH v4 05/16] tests/virtio-blk-test: set up virtqueue after feature negotiation, (continued)
- [PATCH v4 05/16] tests/virtio-blk-test: set up virtqueue after feature negotiation, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 01/16] tests/virtio-blk-test: read config space after feature negotiation, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 03/16] libqos: extend feature bits to 64-bit, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 06/16] libqos: add missing virtio-9p feature negotiation, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 07/16] libqos: enforce Device Initialization order, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step, Stefan Hajnoczi, 2019/10/23
- Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step,
Thomas Huth <=
- [PATCH v4 10/16] libqos: add iteration support to qpci_find_capability(), Stefan Hajnoczi, 2019/10/23
- [PATCH v4 09/16] libqos: access VIRTIO 1.0 vring in little-endian, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 11/16] libqos: pass full QVirtQueue to set_queue_address(), Stefan Hajnoczi, 2019/10/23
- [PATCH v4 12/16] libqos: add MSI-X callbacks to QVirtioPCIDevice, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 13/16] libqos: expose common virtqueue setup/cleanup functions, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 14/16] libqos: make the virtio-pci BAR index configurable, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 15/16] libqos: extract Legacy virtio-pci.c code, Stefan Hajnoczi, 2019/10/23
- [PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support, Stefan Hajnoczi, 2019/10/23
- Re: [PATCH v4 00/16] libqos: add VIRTIO PCI 1.0 support, Michael S. Tsirkin, 2019/10/25