[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 14/19] iotests: remove 'linux' from default supported platform
From: |
Alex Bennée |
Subject: |
[PATCH v1 14/19] iotests: remove 'linux' from default supported platforms |
Date: |
Tue, 22 Oct 2019 20:16:59 +0100 |
From: John Snow <address@hidden>
verify_platform will check an explicit whitelist and blacklist instead.
The default will now be assumed to be allowed to run anywhere.
For tests that do not specify their platforms explicitly, this has the effect of
enabling these tests on non-linux platforms. For tests that always specified
linux explicitly, there is no change.
For Python tests on FreeBSD at least; only seven python tests fail:
045 147 149 169 194 199 211
045 and 149 appear to be misconfigurations,
147 and 194 are the AF_UNIX path too long error,
169 and 199 are bitmap migration bugs, and
211 is a bug that shows up on Linux platforms, too.
This is at least good evidence that these tests are not Linux-only. If
they aren't suitable for other platforms, they should be disabled on a
per-platform basis as appropriate.
Therefore, let's switch these on and deal with the failures.
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-Id: <address@hidden>
---
tests/qemu-iotests/iotests.py | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 3a8f378f90d..75e64ef85be 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -869,9 +869,14 @@ def verify_protocol(supported=[], unsupported=[]):
if not_sup or (imgproto in unsupported):
notrun('not suitable for this protocol: %s' % imgproto)
-def verify_platform(supported_oses=['linux']):
- if True not in [sys.platform.startswith(x) for x in supported_oses]:
- notrun('not suitable for this OS: %s' % sys.platform)
+def verify_platform(supported=None, unsupported=None):
+ if unsupported is not None:
+ if any((sys.platform.startswith(x) for x in unsupported)):
+ notrun('not suitable for this OS: %s' % sys.platform)
+
+ if supported is not None:
+ if not any((sys.platform.startswith(x) for x in supported)):
+ notrun('not suitable for this OS: %s' % sys.platform)
def verify_cache_mode(supported_cache_modes=[]):
if supported_cache_modes and (cachemode not in supported_cache_modes):
@@ -933,7 +938,8 @@ def execute_unittest(output, verbosity, debug):
r'Ran \1 tests', output.getvalue()))
def execute_test(test_function=None,
- supported_fmts=[], supported_oses=['linux'],
+ supported_fmts=[],
+ supported_platforms=None,
supported_cache_modes=[], unsupported_fmts=[],
supported_protocols=[], unsupported_protocols=[]):
"""Run either unittest or script-style tests."""
@@ -950,7 +956,7 @@ def execute_test(test_function=None,
verbosity = 1
verify_image_format(supported_fmts, unsupported_fmts)
verify_protocol(supported_protocols, unsupported_protocols)
- verify_platform(supported_oses)
+ verify_platform(supported=supported_platforms)
verify_cache_mode(supported_cache_modes)
if debug:
--
2.20.1
- [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build, (continued)
- [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build, Alex Bennée, 2019/10/22
- [PATCH v1 08/19] travis.yml: bump Xcode 10 to latest dot release, Alex Bennée, 2019/10/22
- [PATCH v1 05/19] travis.yml: Fix the ccache lines, Alex Bennée, 2019/10/22
- [PATCH v1 13/19] travis.yml: cache the clang sanitizer build, Alex Bennée, 2019/10/22
- [PATCH v1 10/19] tests/vm: netbsd autoinstall, using serial console, Alex Bennée, 2019/10/22
- [PATCH v1 14/19] iotests: remove 'linux' from default supported platforms,
Alex Bennée <=
- [PATCH v1 15/19] iotests: Test 041 only works on certain systems, Alex Bennée, 2019/10/22
- [PATCH v1 16/19] iotests: Test 183 does not work on macOS and OpenBSD, Alex Bennée, 2019/10/22
- [PATCH v1 12/19] tests/vm/netbsd: Disable IPv6, Alex Bennée, 2019/10/22
- [PATCH v1 18/19] iotests: Enable more tests in the 'auto' group to improve test coverage, Alex Bennée, 2019/10/22
- [PATCH v1 19/19] iotests: Remove 130 from the "auto" group, Alex Bennée, 2019/10/22
- [PATCH v1 17/19] iotests: Skip "make check-block" if QEMU does not support virtio-blk, Alex Bennée, 2019/10/22
- Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze, Alex Bennée, 2019/10/22
- Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze, Thomas Huth, 2019/10/23