[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definiti
From: |
Alistair Francis |
Subject: |
Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions |
Date: |
Mon, 21 Oct 2019 13:47:02 -0700 |
On Sun, Oct 20, 2019 at 3:58 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> IEC binary prefixes ease code review: the unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/arm/xilinx_zynq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index c14774e542..3a0fa5b23f 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -16,6 +16,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/units.h"
> #include "qapi/error.h"
> #include "cpu.h"
> #include "hw/sysbus.h"
> @@ -194,7 +195,7 @@ static void zynq_init(MachineState *machine)
> memory_region_add_subregion(address_space_mem, 0, ext_ram);
>
> /* 256K of on-chip memory */
> - memory_region_init_ram(ocm_ram, NULL, "zynq.ocm_ram", 256 << 10,
> + memory_region_init_ram(ocm_ram, NULL, "zynq.ocm_ram", 256 * KiB,
> &error_fatal);
> memory_region_add_subregion(address_space_mem, 0xFFFC0000, ocm_ram);
>
> --
> 2.21.0
>
>
- [PATCH 00/21] hw: Let the machine be the owner of the system memory, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 03/21] hw/arm/collie: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 04/21] hw/arm/omap2: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20
- [PATCH 05/21] hw/arm/omap1: Create the RAM in the board, Philippe Mathieu-Daudé, 2019/10/20