[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 2/9] linux-user/strace: Add print_timezone()
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v8 2/9] linux-user/strace: Add print_timezone() |
Date: |
Mon, 21 Oct 2019 14:49:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
Le 21/10/2019 à 13:48, Philippe Mathieu-Daudé a écrit :
> Suggested-by: Laurent Vivier <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v7: tz_minuteswest and tz_dsttime are abi_int -> %d/tswap32 (lvivier)
>
> checkpatch error:
> ERROR: storage class should be at the beginning of the declaration
> #9: FILE: linux-user/strace.c:66:
> +UNUSED static void print_timezone(abi_ulong, int);
> ---
> linux-user/strace.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index f326c357a2..2cd6687cd9 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -63,6 +63,7 @@ UNUSED static void print_string(abi_long, int);
> UNUSED static void print_buf(abi_long addr, abi_long len, int last);
> UNUSED static void print_raw_param(const char *, abi_long, int);
> UNUSED static void print_timeval(abi_ulong, int);
> +UNUSED static void print_timezone(abi_ulong, int);
> UNUSED static void print_number(abi_long, int);
> UNUSED static void print_signal(abi_ulong, int);
> UNUSED static void print_sockaddr(abi_ulong addr, abi_long addrlen);
> @@ -1254,6 +1255,25 @@ print_timeval(abi_ulong tv_addr, int last)
> gemu_log("NULL%s", get_comma(last));
> }
>
> +static void
> +print_timezone(abi_ulong tz_addr, int last)
> +{
> + if (tz_addr) {
> + struct target_timezone *tz;
> +
> + tz = lock_user(VERIFY_READ, tz_addr, sizeof(*tz), 1);
> + if (!tz) {
> + print_pointer(tz_addr, last);
> + return;
> + }
> + gemu_log("{%d,%d}%s", tswap32(tz->tz_minuteswest),
> + tswap32(tz->tz_dsttime), get_comma(last));
> + unlock_user(tz, tz_addr, 0);
> + } else {
> + gemu_log("NULL%s", get_comma(last));
> + }
> +}
> +
> #undef UNUSED
>
> #ifdef TARGET_NR_accept
>
Reviewed-by: Laurent Vivier <address@hidden>
- Re: [PATCH v8 9/9] linux-user/syscall: Align target_sockaddr fields using ABI types, (continued)
- [PATCH v8 6/9] linux-user/strace: Add print_sockfd(), Philippe Mathieu-Daudé, 2019/10/21
- [PATCH v8 8/9] linux-user/strace: Let print_sockaddr() have a 'last' argument, Philippe Mathieu-Daudé, 2019/10/21
- [PATCH v8 4/9] linux-user/syscall: Introduce target_sockaddr_nl, Philippe Mathieu-Daudé, 2019/10/21
- [PATCH v8 2/9] linux-user/strace: Add print_timezone(), Philippe Mathieu-Daudé, 2019/10/21
- [PATCH v8 7/9] linux-user/strace: Improve bind() output, Philippe Mathieu-Daudé, 2019/10/21
- Re: [PATCH v8 0/9] linux-user: strace improvements, no-reply, 2019/10/21