[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] error: Fix -msg timestamp default
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] error: Fix -msg timestamp default |
|
Date: |
Mon, 21 Oct 2019 09:03:20 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> I'll queue this patch.
Thanks!
> On 10/10/19 10:15, Markus Armbruster wrote:
>> -bool enable_timestamp_msg;
>
> Would you like me to also rename his enable_guestname_msg variable to
> error_with_guest_name?
In my review, I proposed replacing it by error_guest_name, to avoid
having to get -name parameter "guest" all the time. I included a
revised patch to illustrate. Goes on top of this one. My revised patch
doesn't fully address my review. In particular, there's a TODO in the
commit message. Mario, would you be willing to complete it and post it?