[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state
From: |
Richard Henderson |
Subject: |
Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state |
Date: |
Thu, 17 Oct 2019 09:25:44 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/17/19 8:26 AM, Peter Maydell wrote:
> Don't we also need to do something to rebuild the hflags
> for M-profile writes to the memory mapped system registers?
> For instance rebuild_hflags_m32() bakes in state which
> cares about env->v7m.ccr, which is set via nvic_writel(),
> but I don't see anything whereby the write to the NVIC
> register triggers a rebuild of the hflags value. Maybe I
> missed it?
How do you end the TB after nvic_writel(), so that the new behaviour can be
noticed right now? We can call arm_rebuild_hflags() within nvic_writel(), but
it still needs to be recognized somehow. I would expect to place one rebuild
in the place you end the TB...
r~
- Re: [PATCH v6 17/20] target/arm: Rebuild hflags at MSR writes, (continued)
- [PATCH v6 18/20] target/arm: Rebuild hflags at CPSR writes, Richard Henderson, 2019/10/11
- [PATCH v6 19/20] target/arm: Rebuild hflags for M-profile., Richard Henderson, 2019/10/11
- [PATCH v6 20/20] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/11
- [PATCH v6 16/20] target/arm: Rebuild hflags at EL changes, Richard Henderson, 2019/10/11
- Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state, Peter Maydell, 2019/10/17
- Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state,
Richard Henderson <=