Re: [PATCH v19 3/5] ACPI: Add APEI GHES table generation support

[Xiang Zheng]

On 2019/10/15 22:52, Peter Maydell wrote:
> On Tue, 15 Oct 2019 at 15:02, Xiang Zheng <address@hidden> wrote:
>>
>> From: Dongjiu Geng <address@hidden>
>>
>> This patch implements APEI GHES Table generation via fw_cfg blobs. Now
>> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards,
>> we can extend the supported types if needed. For the CPER section,
>> currently it is memory section because kernel mainly wants userspace to
>> handle the memory errors.
>>
>> This patch follows the spec ACPI 6.2 to build the Hardware Error Source
>> table. For more detailed information, please refer to document:
>> docs/specs/acpi_hest_ghes.rst
>>
>> Suggested-by: Laszlo Ersek <address@hidden>
>> Signed-off-by: Dongjiu Geng <address@hidden>
>> Signed-off-by: Xiang Zheng <address@hidden>
> 
>> +    /* Error Status Address */
>> +    build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0,
>> +                     4 /* QWord access */, 0);
> 
> Hi; this doesn't seem to compile with clang:
> 
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:330:34:
> error: implicit conversion from
>       enumeration type 'AmlRegionSpace' to different enumeration type
> 'AmlAddressSpace'
>       [-Werror,-Wenum-conversion]
>     build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0,
>     ~~~~~~~~~~~~~~~~             ^~~~~~~~~~~~~~~~~
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:351:34:
> error: implicit conversion from
>       enumeration type 'AmlRegionSpace' to different enumeration type
> 'AmlAddressSpace'
>       [-Werror,-Wenum-conversion]
>     build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0,
>     ~~~~~~~~~~~~~~~~             ^~~~~~~~~~~~~~~~~
> 2 errors generated.
> 
> Should these be AML_AS_SYSTEM_MEMORY, or should the build_append_gas()
> function be taking an AmlRegionSpace rather than an AmlAddressSpace ?

Yes, these should be AML_AS_SYSTEM_MEMORY, the first field of Generic Address
Structure(GAS) is Address Space ID. I will fix these compile errors.

> 
> thanks
> -- PMM
> 
> .
> 

-- 

Thanks,
Xiang