[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/10] image-fuzzer: Open image files in binary mode
From: |
Eduardo Habkost |
Subject: |
[PATCH 01/10] image-fuzzer: Open image files in binary mode |
Date: |
Wed, 16 Oct 2019 16:24:21 -0300 |
This probably never caused problems because on Linux there's no
actual newline conversion happening, but on Python 3 the
binary/text distinction is stronger and we must explicitly open
the image file in binary mode.
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/image-fuzzer/qcow2/layout.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py
b/tests/image-fuzzer/qcow2/layout.py
index 675877da96..c57418fa15 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -503,7 +503,7 @@ class Image(object):
def write(self, filename):
"""Write an entire image to the file."""
- image_file = open(filename, 'w')
+ image_file = open(filename, 'wb')
for field in self:
image_file.seek(field.offset)
image_file.write(struct.pack(field.fmt, field.value))
--
2.21.0
- [PATCH 00/10] image-fuzzer: Port to Python 3, Eduardo Habkost, 2019/10/16
- [PATCH 01/10] image-fuzzer: Open image files in binary mode,
Eduardo Habkost <=
- [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file, Eduardo Habkost, 2019/10/16
- [PATCH 03/10] image-fuzzer: Explicitly use integer division operator, Eduardo Habkost, 2019/10/16
- [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__(), Eduardo Habkost, 2019/10/16
- [PATCH 04/10] image-fuzzer: Use io.StringIO, Eduardo Habkost, 2019/10/16
- [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions, Eduardo Habkost, 2019/10/16
- [PATCH 07/10] image-fuzzer: Use bytes constant for field values, Eduardo Habkost, 2019/10/16