[RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

[Vladimir Sementsov-Ogievskiy]

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---

CC: Gerd Hoffmann <address@hidden>
CC: "Gonglei (Arei)" <address@hidden>
CC: Eduardo Habkost <address@hidden>
CC: Igor Mammedov <address@hidden>
CC: Laurent Vivier <address@hidden>
CC: Amit Shah <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
CC: John Snow <address@hidden>
CC: Ari Sundholm <address@hidden>
CC: Pavel Dovgalyuk <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Fam Zheng <address@hidden>
CC: Stefan Weil <address@hidden>
CC: Ronnie Sahlberg <address@hidden>
CC: Peter Lieven <address@hidden>
CC: Eric Blake <address@hidden>
CC: "Denis V. Lunev" <address@hidden>
CC: Markus Armbruster <address@hidden>
CC: Alberto Garcia <address@hidden>
CC: Jason Dillaman <address@hidden>
CC: Wen Congyang <address@hidden>
CC: Xie Changlong <address@hidden>
CC: Liu Yuan <address@hidden>
CC: "Richard W.M. Jones" <address@hidden>
CC: Jeff Cody <address@hidden>
CC: "Marc-André Lureau" <address@hidden>
CC: "Daniel P. Berrangé" <address@hidden>
CC: Richard Henderson <address@hidden>
CC: Greg Kurz <address@hidden>
CC: "Michael S. Tsirkin" <address@hidden>
CC: Marcel Apfelbaum <address@hidden>
CC: Beniamino Galvani <address@hidden>
CC: Peter Maydell <address@hidden>
CC: "Cédric Le Goater" <address@hidden>
CC: Andrew Jeffery <address@hidden>
CC: Joel Stanley <address@hidden>
CC: Andrew Baumann <address@hidden>
CC: "Philippe Mathieu-Daudé" <address@hidden>
CC: Antony Pavlov <address@hidden>
CC: Jean-Christophe Dubois <address@hidden>
CC: Peter Chubb <address@hidden>
CC: Subbaraya Sundeep <address@hidden>
CC: Eric Auger <address@hidden>
CC: Alistair Francis <address@hidden>
CC: "Edgar E. Iglesias" <address@hidden>
CC: Stefano Stabellini <address@hidden>
CC: Anthony Perard <address@hidden>
CC: Paul Durrant <address@hidden>
CC: Paul Burton <address@hidden>
CC: Aleksandar Rikalo <address@hidden>
CC: Chris Wulff <address@hidden>
CC: Marek Vasut <address@hidden>
CC: David Gibson <address@hidden>
CC: Cornelia Huck <address@hidden>
CC: Halil Pasic <address@hidden>
CC: Christian Borntraeger <address@hidden>
CC: "Hervé Poussineau" <address@hidden>
CC: Xiao Guangrong <address@hidden>
CC: Aurelien Jarno <address@hidden>
CC: Aleksandar Markovic <address@hidden>
CC: Mark Cave-Ayland <address@hidden>
CC: Jason Wang <address@hidden>
CC: Laszlo Ersek <address@hidden>
CC: Yuval Shaia <address@hidden>
CC: Palmer Dabbelt <address@hidden>
CC: Sagar Karandikar <address@hidden>
CC: Bastian Koppelmann <address@hidden>
CC: David Hildenbrand <address@hidden>
CC: Thomas Huth <address@hidden>
CC: Eric Farman <address@hidden>
CC: Matthew Rosato <address@hidden>
CC: Hannes Reinecke <address@hidden>
CC: Michael Walle <address@hidden>
CC: Artyom Tarasenko <address@hidden>
CC: Stefan Berger <address@hidden>
CC: Samuel Thibault <address@hidden>
CC: Alex Williamson <address@hidden>
CC: Tony Krowiak <address@hidden>
CC: Pierre Morel <address@hidden>
CC: Michael Roth <address@hidden>
CC: Hailiang Zhang <address@hidden>
CC: Juan Quintela <address@hidden>
CC: "Dr. David Alan Gilbert" <address@hidden>
CC: Luigi Rizzo <address@hidden>
CC: Giuseppe Lettieri <address@hidden>
CC: Vincenzo Maffione <address@hidden>
CC: Jan Kiszka <address@hidden>
CC: Anthony Green <address@hidden>
CC: Stafford Horne <address@hidden>
CC: Guan Xuetao <address@hidden>
CC: Max Filippov <address@hidden>
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden

 scripts/coccinelle/auto-propagated-errp.cocci | 118 ++++++++++++++++++
 1 file changed, 118 insertions(+)
 create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci

diff --git a/scripts/coccinelle/auto-propagated-errp.cocci 
b/scripts/coccinelle/auto-propagated-errp.cocci
new file mode 100644
index 0000000000..d9731620aa
--- /dev/null
+++ b/scripts/coccinelle/auto-propagated-errp.cocci
@@ -0,0 +1,118 @@
+@rule0@
+// Add invocation to errp-functions where necessary
+identifier fn, local_err;
+symbol errp;
+@@
+
+ fn(..., Error **errp, ...)
+ {
++   ERRP_AUTO_PROPAGATE();
+    <+...
+(
+    error_append_hint(errp, ...);
+|
+    error_prepend(errp, ...);
+|
+    Error *local_err = NULL;
+)
+    ...+>
+ }
+
+@@
+// Drop doubled invocation
+identifier rule0.fn;
+@@
+
+ fn(...)
+{
+-   ERRP_AUTO_PROPAGATE();
+    ERRP_AUTO_PROPAGATE();
+    ...
+}
+
+@rule1@
+// Drop local_err
+identifier fn, local_err;
+symbol errp;
+@@
+
+ fn(..., Error **errp, ...)
+ {
+     <...
+-    Error *local_err = NULL;
+     ...>
+ }
+
+@@
+// Handle pattern with goto, otherwise we'll finish up
+// with labels at function end which will not compile.
+identifier rule1.fn;
+identifier rule1.local_err;
+identifier OUT;
+@@
+
+ fn(...)
+ {
+     <...
+-    goto OUT;
++    return;
+     ...>
+- OUT:
+-    error_propagate(errp, local_err);
+ }
+
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+     <...
+(
+-    error_free(local_err);
+-    local_err = NULL;
++    error_free_errp(errp);
+|
+-    error_free(local_err);
++    error_free_errp(errp);
+|
+-    error_report_err(local_err);
++    error_report_errp(errp);
+|
+-    warn_report_err(local_err);
++    warn_report_errp(errp);
+|
+-    error_propagate_prepend(errp, local_err,
++    error_prepend(errp,
+                              ...);
+|
+-    error_propagate(errp, local_err);
+)
+     ...>
+ }
+
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+     <...
+(
+-    &local_err
++    errp
+|
+-    local_err
++    *errp
+)
+     ...>
+ }
+
+@@
+symbol errp;
+@@
+
+- *errp != NULL
++ *errp
-- 
2.21.0