[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] migration/multifd: initialize packet->magic/version once
|
From: |
Wei Yang |
|
Subject: |
Re: [PATCH 3/4] migration/multifd: initialize packet->magic/version once at setup stage |
|
Date: |
Fri, 11 Oct 2019 12:17:24 +0000 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Oct 11, 2019 at 12:20:48PM +0200, Juan Quintela wrote:
>Wei Yang <address@hidden> wrote:
>> MultiFDPacket_t's magic and version field never changes during
>> migration, so move these two fields in setup stage.
>>
>> Signed-off-by: Wei Yang <address@hidden>
>
>Reviewed-by: Juan Quintela <address@hidden>
>
>It don't really matter, and is faster your way O:-)
You are right.
And I am wondering one more thing. Why we need to carry magic/version for each
packet? Would it be better to just carry and check magic/version for the
initial packet only?
--
Wei Yang
Help you, Help me
- [PATCH 0/4] migration/multifd: trivial cleanup for multifd, Wei Yang, 2019/10/11
- [PATCH 1/4] migration/multifd: fix a typo in comment of multifd_recv_unfill_packet(), Wei Yang, 2019/10/11
- [PATCH 2/4] migration/multifd: use pages->allocated instead of the static max, Wei Yang, 2019/10/11
- [PATCH 3/4] migration/multifd: initialize packet->magic/version once at setup stage, Wei Yang, 2019/10/11
- [PATCH 4/4] migration/multifd: pages->used would be cleared when attach to multifd_send_state, Wei Yang, 2019/10/11
- Re: [PATCH 0/4] migration/multifd: trivial cleanup for multifd, Dr. David Alan Gilbert, 2019/10/11