qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support


From: Stefan Hajnoczi
Subject: Re: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support
Date: Fri, 11 Oct 2019 09:33:54 +0100
User-agent: Mutt/1.12.1 (2019-06-15)

On Thu, Oct 10, 2019 at 02:12:00PM -0700, address@hidden wrote:
> 4/7 Checking commit e3477ab2dc8e (libqos: add MSI-X callbacks to 
> QVirtioPCIDevice)
> ERROR: line over 90 characters
> #31: FILE: tests/libqos/virtio-pci.c:283:
> +static void qvirtio_pci_set_queue_vector(QVirtioPCIDevice *d, uint16_t 
> vq_idx, uint16_t entry)
[...]
> 7/7 Checking commit f7c93099d7df (libqos: add VIRTIO PCI 1.0 support)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
[...]
> ERROR: line over 90 characters
> #235: FILE: tests/libqos/virtio-pci-modern.c:198:
> +static QVirtQueue *virtqueue_setup(QVirtioDevice *d, QGuestAllocator *alloc, 
> uint16_t index)
> 
> WARNING: line over 80 characters
> #298: FILE: tests/libqos/virtio-pci-modern.c:261:
> +static void set_queue_vector(QVirtioPCIDevice *d, uint16_t vq_idx, uint16_t 
> entry)
> 
> WARNING: Block comments use a leading /* on a separate line
> #328: FILE: tests/libqos/virtio-pci-modern.c:291:
> +    /* "Any PCI device with ... PCI Device ID 0x1000 through 0x107F inclusive
> 
> WARNING: Block comments use a leading /* on a separate line
> #336: FILE: tests/libqos/virtio-pci-modern.c:299:
> +    /* "Devices MAY utilize a Transitional PCI Device ID range, 0x1000 to
> 
> WARNING: Block comments use a leading /* on a separate line
> #340: FILE: tests/libqos/virtio-pci-modern.c:303:
> +        /* "Transitional devices MUST have the PCI Subsystem Device ID 
> matching
> 
> WARNING: Block comments use a leading /* on a separate line
> #345: FILE: tests/libqos/virtio-pci-modern.c:308:
> +        /* "The PCI Device ID is calculated by adding 0x1040 to the Virtio
> 
> WARNING: Block comments use a leading /* on a separate line
> #393: FILE: tests/libqos/virtio-pci-modern.c:356:
> +    /* Due to the qpci_iomap() API we only support devices that put all

Will fix these in v2.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]