|
From: | Li Qiang |
Subject: | Re: [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler |
Date: | Thu, 10 Oct 2019 09:18:25 +0800 |
The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().
Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/misc/vmcoreinfo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c
index 326a3ce8f4..a9d718fc23 100644
--- a/hw/misc/vmcoreinfo.c
+++ b/hw/misc/vmcoreinfo.c
@@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp)
NULL, fw_cfg_vmci_write, s,
&s->vmcoreinfo, sizeof(s->vmcoreinfo), false);
+ /*
+ * This device requires to register a global reset because it is
+ * not plugged to a bus (which, as its QOM parent, would reset it).
+ */
qemu_register_reset(vmcoreinfo_reset, dev);
vmcoreinfo_state = s;
}
--
2.21.0
[Prev in Thread] | Current Thread | [Next in Thread] |