Re: [PATCH 11/11] hw/misc/vmcoreinfo: Convert reset handler to DeviceReset

[Eduardo Habkost]

On Thu, Sep 26, 2019 at 06:02:47PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/26/19 5:17 PM, Philippe Mathieu-Daudé wrote:
> > Convert the reset handler into a proper Device reset method.
> 
> Marc-André noticed this one is incorrect, because while being QDEV it is
> not connected to a QBUS.
> 
> Maybe we can add a Device::unconnected property, and when set, the
> parent realize() calls 'qemu_register_reset(dev->reset, dev);'?
> This might look the same, but at least Devices implementations could
> stop to use this function...

Can we make this automatic instead of requiring another explicit
setting?

Today we have at least 3 different ways of getting a device to be
reset: qemu_register_reset(); explicit device_reset_all() call in
another reset handler; and implicit device_reset_all() call done
through parent buses/devices.  I wouldn't like to create a 4th
method.

What I really wish for, is a opt-out mechanism for reset (meaning
all devices would be guaranteed to be reset unless they
explicitly opt out), instead of 3 or 4 different opt-in
mechanisms.

-- 
Eduardo