[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller
From: |
Krzysztof Kozlowski |
Subject: |
Re: [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller |
Date: |
Mon, 7 Oct 2019 10:59:31 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Sat, Oct 05, 2019 at 05:47:46PM +0200, Philippe Mathieu-Daudé wrote:
> The Linux kernel access few S3C-specific registers [1] to set some
> clock. We don't care about this part for device emulation [2]. Add
> a dummy device to properly ignore these accesses, so we can focus
> on the important registers missing.
The CONTROL2 has also few other settings, not clock related, but they
can be skipped as well.
Reviewed-by: Krzysztof Kozlowski <address@hidden>
Best regards,
Krzysztof
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci-s3c-regs.h?h=cc014f3
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci-s3c.c?h=v5.3#n263
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Eventually we should add the ADMA changes Igor sent in this patch:
> https://patchwork.ozlabs.org/patch/181854/
> They might solve the boot timing issues when using SD cards.
> ---
> hw/sd/sdhci.c | 65 +++++++++++++++++++++++++++++++++++++++++++
> include/hw/sd/sdhci.h | 2 ++
> 2 files changed, 67 insertions(+)
>
- [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board, Philippe Mathieu-Daudé, 2019/10/05
- [PATCH 2/5] hw/sd/sdhci: Add a comment to distinct the i.MX eSDHC functions, Philippe Mathieu-Daudé, 2019/10/05
- [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller, Philippe Mathieu-Daudé, 2019/10/05
- Re: [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller,
Krzysztof Kozlowski <=
- [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Philippe Mathieu-Daudé, 2019/10/05
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Peter Maydell, 2019/10/07
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Cleber Rosa, 2019/10/08
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Guenter Roeck, 2019/10/08
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Peter Maydell, 2019/10/09
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Cleber Rosa, 2019/10/09
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Philippe Mathieu-Daudé, 2019/10/10
- Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Philippe Mathieu-Daudé, 2019/10/21
Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210, Cleber Rosa, 2019/10/08
[PATCH 4/5] hw/arm/exynos4210: Use the Samsung s3c SDHCI controller, Philippe Mathieu-Daudé, 2019/10/05