Re: [PATCH 2/7] spapr, xive: Turn "nr-ends" property into "nr-servers" property

[Cédric Le Goater]

On 04/10/2019 08:52, Greg Kurz wrote:
> On Fri, 4 Oct 2019 07:53:13 +0200
> Cédric Le Goater <address@hidden> wrote:
> 
>>>> @@ -283,11 +292,13 @@ static void spapr_xive_realize(DeviceState *dev, 
>>>> Error **errp)
>>>>          return;
>>>>      }
>>>>  
>>>> -    if (!xive->nr_ends) {
>>>> -        error_setg(errp, "Number of interrupt needs to be greater 0");
>>>> +    if (!xive->nr_servers) {
>>>> +        error_setg(errp, "Number of interrupt servers must be greater 
>>>> than 0");
>>>>          return;
>>>>      }
>>>>  
>>>> +    xive->nr_ends = spapr_xive_vcpu_id_to_end_idx(xive->nr_servers);
>>>
>>> I'd prefer not to store both nr_servers and nr_servers * 8 in the
>>> structure.  I think you just want xive->nr_servers, then derive it any
>>> any places that current look at xive->nr_ends.
>>
>> Yes I agree. This is a small change.
>>
> 
> I'm afraid it isn't that simple (see my other mail).

yes. I had forgotten about the vmstate ...