Re: [PULL 0/8] Ide patches

[John Snow]

On 10/3/19 11:35 AM, Peter Maydell wrote:
> On Wed, 2 Oct 2019 at 00:56, John Snow <address@hidden> wrote:
>>
>> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
>>
>>   Merge remote-tracking branch 
>> 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 
>> 13:13:38 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://github.com/jnsnow/qemu.git tags/ide-pull-request
>>
>> for you to fetch changes up to d5eedf4633376d22a34a17a061d3ed47ddb6fee0:
>>
>>   hd-geo-test: Add tests for lchs override (2019-10-01 17:50:16 -0400)
>>
>> ----------------------------------------------------------------
>> "IDE" Pull request. (CHS changes for SeaBios)
>>
>> ----------------------------------------------------------------
>>
>> Sam Eiderman (8):
>>   block: Refactor macros - fix tabbing
>>   block: Support providing LCHS from user
>>   bootdevice: Add interface to gather LCHS
>>   scsi: Propagate unrealize() callback to scsi-hd
>>   bootdevice: Gather LCHS from all relevant devices
>>   bootdevice: Refactor get_boot_devices_list
>>   bootdevice: FW_CFG interface for LCHS values
>>   hd-geo-test: Add tests for lchs override
> 
> Hi John -- it looks like you forgot to put your signed-off-by
> as the maintainer on the commits in this pullreq. Could you
> fix that and resend, please?
> 

... I see what happened now, actually.

The emails got signed but the commits didn't.

I didn't sign them when I applied the patches, but I signed them when
using git-publish --pull-request --signoff, and it applies the signature
before send, but after mirroring.

I'll try to fix that when I have the time to make sure it doesn't happen
again.

--js