Re: [PATCH v2 0/6] qcow2: advanced compression options

[Max Reitz]

On 02.10.19 17:35, Vladimir Sementsov-Ogievskiy wrote:
> Hi,
> 
> 02.10.2019 18:07, address@hidden wrote:
>> Patchew URL: https://patchew.org/QEMU/address@hidden/
>>
>>
>>
>> Hi,
>>
>> This series failed the docker-quick@centos7 build test. Please find the 
>> testing commands and
>> their output below. If you have Docker installed, you can probably reproduce 
>> it
>> locally.
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> make docker-image-centos7 V=1 NETWORK=1
>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
>> === TEST SCRIPT END ===
>>
>>    CC      block/parallels.o
>>    CC      block/blklogwrites.o
>>    CC      block/block-backend.o
>> /tmp/qemu-test/src/block/qcow2.c:4077:64: error: unknown type name 'AioTask'
>>   static coroutine_fn int qcow2_co_pwritev_compressed_task_entry(AioTask 
>> *task)
>>                                                                  ^
>> /tmp/qemu-test/src/block/qcow2.c: In function 
>> 'qcow2_co_pwritev_compressed_part':
>> /tmp/qemu-test/src/block/qcow2.c:4098:5: error: unknown type name 
>> 'AioTaskPool'
>>       AioTaskPool *aio = NULL;
>>       ^
> 
> 
> Who knows, what is wrong with it? Seems patchew ignores Based-on: tag in 
> cover-letter,
> which is written as "Based-on: https://github.com/XanClic/qemu.git block"...
> These new types and functions are defined in Max's block branch.

It would be news to me if Patchew supported such URLs.  I just put it
into my cover letter for human reviewers...

(Actually, it would be news to me if Patchew supported Based-on at all
reliably...)

Max

signature.asc
Description: OpenPGP digital signature